Re: [patch] eicon: make buffer larger

Armin Schindler
2010-10-06T07:43:47Z

On Mon, 4 Oct 2010, Dan Carpenter wrote:
> In diva_mnt_add_xdi_adapter() we do this:
> strcpy (clients[id].drvName, tmp);
> strcpy (clients[id].Dbg.drvName, tmp);
>
> The "clients[id].drvName" is a 128 character buffer and
> "clients[id].Dbg.drvName" was originally a 16 character buffer but I've
> changed it to 128 as well. We don't actually use 128 characters but we
> do use more than 16.

I don't see any reason for that change. The driver names here do not use
more than 16 characters and when filled, the length is checked anyway.
Please avoid changing the size of that structure.

Armin

> I've also changed the size of "tmp" to 128 characters instead of 256.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/isdn/hardware/eicon/debuglib.h b/drivers/isdn/hardware/eicon/debuglib.h
> index 8ea5877..02eed6b 100644
> --- a/drivers/isdn/hardware/eicon/debuglib.h
> +++ b/drivers/isdn/hardware/eicon/debuglib.h
> @@ -249,7 +249,7 @@ typedef struct _DbgHandle_
> } regTime ; /* timestamp for registration */
> void *pIrp ; /* ptr to pending i/o request */
> unsigned long dbgMask ; /* current debug mask */
> - char drvName[16] ; /* ASCII name of registered driver */
> + char drvName[128] ; /* ASCII name of registered driver */
> char drvTag[64] ; /* revision string */
> DbgEnd dbg_end ; /* function for debug closing */
> DbgLog dbg_prt ; /* function for debug appending */
> diff --git a/drivers/isdn/hardware/eicon/debug.c b/drivers/isdn/hardware/eicon/debug.c
> index 33ce89e..3626401 100644
> --- a/drivers/isdn/hardware/eicon/debug.c
> +++ b/drivers/isdn/hardware/eicon/debug.c
> @@ -862,7 +862,7 @@ void diva_mnt_add_xdi_adapter (const DESCRIPTOR* d) {
> diva_os_spin_lock_magic_t old_irql, old_irql1;
> dword sec, usec, logical, serial, org_mask;
> int id, best_id = 0, free_id = -1;
> - char tmp[256];
> + char tmp[128];
> diva_dbg_entry_head_t* pmsg = NULL;
> int len;
> word size;
>