From: Wolfgang Grandegger <wg@grandegger.com>
To: David Miller <davem@davemloft.net>
Cc: masa-korg@dsn.okisemi.com, andrew.chih.howe.khor@intel.com,
sameo@linux.intel.com, margie.foster@intel.com,
netdev@vger.kernel.org, yong.y.wang@intel.com,
linux-kernel@vger.kernel.org, socketcan-core@lists.berlios.de,
mkl@pengutronix.de, chripell@fsfe.org,
morinaga526@dsn.okisemi.com, meego-dev@meego.com,
kok.howg.ewe@intel.com, joel.clark@intel.com, qi.wang@intel.com
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Wed, 06 Oct 2010 11:12:52 +0200 [thread overview]
Message-ID: <4CAC3D94.9010408@grandegger.com> (raw)
In-Reply-To: <20101005.200904.71120150.davem@davemloft.net>
On 10/06/2010 05:09 AM, David Miller wrote:
> From: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>
> Date: Wed, 6 Oct 2010 12:07:15 +0900
>
>> Does your mail mean, for accepting upstream, NAPI is essential for
>> CAN driver ?
>
> It is up to the CAN maintainers :-)
Well, our SJA1000 reference driver does still not use NAPI. But NAPI is
for CAN especially useful to avoid the infamous *bus error irq
flooding*, which may hang low end systems if the interrupts are handled
in the IRQ context. Ohtake, if your system can handle well such CAN bus
error irq storms at 1MB/s, then NAPI is *not* a must to have. Anyway, as
you are at it, I also suggest to use NAPI right from the beginning.
Wolfgang.
next prev parent reply other threads:[~2010-10-06 9:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 10:24 [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35 Masayuki Ohtak
2010-09-27 8:38 ` Wolfgang Grandegger
2010-09-30 9:10 ` Wolfgang Grandegger
2010-09-30 18:50 ` David Miller
2010-10-01 10:02 ` Masayuki Ohtake
2010-10-01 12:40 ` Wolfgang Grandegger
2010-10-05 10:21 ` Masayuki Ohtake
2010-10-05 11:08 ` Marc Kleine-Budde
2010-10-05 12:09 ` Masayuki Ohtake
2010-10-05 18:45 ` David Miller
2010-10-06 3:07 ` Masayuki Ohtake
2010-10-06 3:09 ` David Miller
2010-10-06 9:12 ` Wolfgang Grandegger [this message]
2010-10-12 7:09 ` Masayuki Ohtake
2010-10-12 7:42 ` Wolfgang Grandegger
2010-10-12 7:56 ` Marc Kleine-Budde
2010-10-13 4:23 ` Masayuki Ohtake
2010-10-13 7:38 ` Marc Kleine-Budde
2010-10-13 10:09 ` Masayuki Ohtake
2010-10-13 11:08 ` Wolfgang Grandegger
2010-10-13 12:05 ` Masayuki Ohtake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAC3D94.9010408@grandegger.com \
--to=wg@grandegger.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=mkl@pengutronix.de \
--cc=morinaga526@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox