From: David Daney <ddaney@caviumnetworks.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, abbotti@mev.co.uk, fmhess@users.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors
Date: Wed, 06 Oct 2010 10:54:11 -0700 [thread overview]
Message-ID: <4CACB7C3.9030000@caviumnetworks.com> (raw)
In-Reply-To: <1286326843-6170-7-git-send-email-tdent48227@gmail.com>
On 10/05/2010 06:00 PM, Tracey Dent wrote:
> Changed a few lines that made checkpatch.pl complain. Could not get ever warning but
> I got it down to to just 4, WARNING: line over 80 characters.
The overall goal is to improve the code, not placate checkpatch.pl
[...]
> printk
> - (KERN_WARNING "BUG! detaching device with use_count=%d\n",
> - dev->use_count);
> + (KERN_WARNING "BUG! detaching device \
> + with use_count=%d\n",
> + dev->use_count);
Is that really an improvement?
And even if it were, is that really how strings should be split up?
Hint:
pr_warning("BUG! detaching device with use_count=%d\n",
dev->use_count);
David Daney
next prev parent reply other threads:[~2010-10-06 17:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 1:00 [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 02/28] Staging: comedi: comedi_compat32.c: Edit file so that checkpatch.pl " Tracey Dent
2010-10-06 1:00 ` [PATCH 03/28] Staging: comedi: comedi_compat32.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 04/28] Staging: comedi: comedidev.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 05/28] Staging: comedi: comedi_fops.c: Edit file so that checkpatch.pl has 1 warnings and 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 06/28] Staging: comedi: comedilib.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors Tracey Dent
2010-10-06 4:48 ` Dan Carpenter
2010-10-06 17:54 ` David Daney [this message]
2010-10-06 1:00 ` [PATCH 08/28] Staging: comedi: proc.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 09/28] Staging: comedi: range.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 10/28] Staging: comedi: kcomedilib: kcomedilib_main.c: " Tracey Dent
2010-10-06 4:44 ` Dan Carpenter
2010-10-06 1:00 ` [PATCH 11/28] Staging: comedi: drivers: 8253.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 12/28] Staging: comedi: drivers: 8255.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 13/28] Staging: comedi: drivers: 8255.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 14/28] Staging: comedi: drivers: adl_pci2608.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 15/28] Staging: comedi: drivers: adl_pci7230.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 16/28] Staging: comedi: drivers: adl_pci7296.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 17/28] Staging: comedi: drivers: adl_pci7432.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 18/28] Staging: comedi: drivers: adl_pci8164.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 19/28] Staging: comedi: drivers: adl_pci9111.c: Edit file so that checkpatch.pl has 30 warnings and 3 errors Tracey Dent
2010-10-06 4:34 ` Dan Carpenter
2010-10-06 1:00 ` [PATCH 20/28] Staging: comedi: drivers: adl_pci9118.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 21/28] Staging: comedi: drivers: adq12b.c: Edit file so that checkpatch.pl has 0 errors and 2 warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 22/28] Staging: comedi: drivers: adv_pci1710.c: Edit file so that checkpatch.pl complains a little less Tracey Dent
2010-10-06 1:00 ` [PATCH 23/28] Staging: comedi: drivers: adv_pci1723.c: Edit file so that checkpatch.pl has 0 warnings and 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 24/28] Staging: comedi: drivers: adv_pci_dio.c: Edit file so that checkpatch.pl has 3 warnings and 1 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 25/28] Staging: comedi: drivers: aio_aio12_8.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 26/28] Staging: comedi: drivers: aio_iiro_16.c: " Tracey Dent
2010-10-06 1:00 ` [PATCH 27/28] Staging: comedi: drivers: am9513.h: " Tracey Dent
2010-10-06 1:00 ` [PATCH 28/28] Staging: comedi: drivers: amcc_s5933.h: Edit file so that checkpatch.pl has 2 warnings and 0 errors Tracey Dent
2010-10-06 1:50 ` [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings Greg KH
2010-10-06 2:01 ` T Dent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CACB7C3.9030000@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=abbotti@mev.co.uk \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox