RE: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging

Savoy, Pavan
2010-10-20T16:04:40Z

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Wednesday, October 20, 2010 12:22 AM
> To: Savoy, Pavan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; alan@lxorguk.ukuu.org.uk;
> devel@driverdev.osuosl.org
> Subject: Re: [PATCH 1/2] drivers:staging:ti-st: move TI_ST from staging
>
> On Wed, 6 Oct 2010 12:18:14 -0400 pavan_savoy@ti.com wrote:
>
> > +/**
> > + * st_reg_complete -
> > + * to call registration complete callbacks
> > + * of all protocol stack drivers
> > + */
> > +void st_reg_complete(struct st_data_s *st_gdata, char err)
>
> The driver has a lot of "kerneldoc" comments which are incomplete -
> they don't document the arguments.

For functions too?
Sure Andrew, I will post a patch to comment the arguments soon.

Thanks for the comments.