From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled
Date: Thu, 07 Oct 2010 18:32:06 +0200 [thread overview]
Message-ID: <4CADF606.70001@metafoo.de> (raw)
In-Reply-To: <1286437880.18303.2.camel@mola>
Axel Lin wrote:
> When enabled is false, clear BIT(engine) of JZ_REG_ADC_ENABLE register.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
- Lars
> ---
> drivers/mfd/jz4740-adc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index 3ad492c..9dd1b33 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -153,7 +153,7 @@ static inline void jz4740_adc_set_enabled(struct jz4740_adc *adc, int engine,
> if (enabled)
> val |= BIT(engine);
> else
> - val &= BIT(engine);
> + val &= ~BIT(engine);
> writeb(val, adc->base + JZ_REG_ADC_ENABLE);
>
> spin_unlock_irqrestore(&adc->lock, flags);
next prev parent reply other threads:[~2010-10-07 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 7:51 [PATCH] mfd: jz4740-adc - fix jz4740_adc_set_enabled Axel Lin
2010-10-07 16:32 ` Lars-Peter Clausen [this message]
2010-10-19 9:12 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CADF606.70001@metafoo.de \
--to=lars@metafoo.de \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox