Re: [PATCH v5] usb: usb3.0 ch9 definitions

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 09-10-2010 18:46, Tatyana Brokhman wrote:

> Adding SuperSpeed usb definitions as defined by ch9 of the USB3.0 spec.
> This patch is a preparation for adding SuperSpeed support to the gadget
> framework.

> Signed-off-by: Tatyana Brokhman<tlinder@codeaurora.org>
> ---
>   include/linux/usb/ch9.h |   58 ++++++++++++++++++++++++++++++++++++++++++++++-
>   1 files changed, 57 insertions(+), 1 deletions(-)

> diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h
> index da2ed77..fc5506f 100644
> --- a/include/linux/usb/ch9.h
> +++ b/include/linux/usb/ch9.h
[...]
> @@ -712,16 +728,56 @@ struct usb_wireless_cap_descriptor {	/* Ultra Wide Band */
>   	__u8  bReserved;
>   } __attribute__((packed));
>
> +/* USB 2.0 Extension descriptor */
>   #define	USB_CAP_TYPE_EXT		2
>
>   struct usb_ext_cap_descriptor {		/* Link Power Management */
>   	__u8  bLength;
>   	__u8  bDescriptorType;
>   	__u8  bDevCapabilityType;
> -	__u8  bmAttributes;
> +	__le32 bmAttributes;
>   #define USB_LPM_SUPPORT			(1<<  1)	/* supports LPM */
>   } __attribute__((packed));
>
> +#define USB_DT_USB_EXT_CAP_SIZE	7
> +
> +/*
> + * SuperSpeed USB Capability descriptor: Defines the set of SuperSpeed USB
> + * specific device level capabilities
> + */
> +#define		USB_SS_CAP_TYPE		3

    Too many tabs here.

> +struct usb_ss_cap_descriptor {		/* Link Power Management */

WBR, Sergei