From: Chris Bagwell <chris@cnpbagwell.com>
To: Chase Douglas <chase.douglas@canonical.com>
Cc: linux-input@vger.kernel.org, xorg-devel@lists.x.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.de>, Andy Whitcroft <apw@canonical.com>,
Henrik Rydberg <rydberg@euromail.se>,
linux-kernel@vger.kernel.org,
Peter Hutterer <peter.hutterer@who-t.net>,
Duncan McGreggor <duncan.mcgreggor@canonical.com>
Subject: Re: [PATCH 3/3] Input: synaptics - remove touches over button click area
Date: Sun, 10 Oct 2010 10:58:28 -0500 [thread overview]
Message-ID: <4CB1E2A4.4000000@cnpbagwell.com> (raw)
In-Reply-To: <1286549880-32580-4-git-send-email-chase.douglas@canonical.com>
On 10/08/2010 09:58 AM, Chase Douglas wrote:
> Now that we have proper multitouch support, we can handle integrated
> buttons better. If we know the top of the buttons on the touchpad, we
> can ignore any touches that occur within the touchpad area while a
> button is clicked. It may be possible to get the button area by querying
> the device, but for now allow the user to manually set it.
>
> A note on why this works: the Synaptics touchpads have pseudo touch
> tracking. When two touches are on the touchpad, an MT touch packet with
> just the X, Y, and pressure values is sent before a normal Synaptics
> touch packet. When one touch is obviously in motion and the other is
> stationary, the touchpad controller sends the touch in motion in the
> normal packet and the stationary touch in the MT packet. Single touch
> emulation is provided by the normal packet, so an action like clicking
> a button and dragging with another finger still works as expected.
>
> Tested on a Dell Mini 1012 with synaptics_multitouch=1 and
> synaptics_button_thresh=4100.
>
Even if we did not submit the MT logic, I'd go a totally different
direction and move clickpad button press support fully to
xf86-input-synaptics and I'd remove the logic from kernel side that maps
HW's middle button to left button. It seems just limping a long with
single button support anyways.
I haven't had time to review Takashi's xf86-input-synaptics patches just
sent yet but seems along this line of thinking as well.
Chris
next prev parent reply other threads:[~2010-10-10 15:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 14:57 [PATCH 0/3] Input: synaptics - multitouch and multifinger support Chase Douglas
2010-10-08 14:57 ` [PATCH 1/3] Input: synaptics - add multitouch support Chase Douglas
2010-10-08 14:57 ` [PATCH 2/3] Input: synaptics - add multitouch multifinger support Chase Douglas
2010-10-08 14:58 ` [PATCH 3/3] Input: synaptics - remove touches over button click area Chase Douglas
2010-10-10 15:58 ` Chris Bagwell [this message]
2010-10-11 16:24 ` Chris Bagwell
2010-10-11 17:10 ` Takashi Iwai
2010-10-11 17:30 ` Dmitry Torokhov
2010-10-11 17:40 ` Takashi Iwai
2010-10-11 17:46 ` Chris Bagwell
2010-10-11 17:54 ` Henrik Rydberg
2010-10-11 18:29 ` Takashi Iwai
2010-10-10 15:44 ` [PATCH 2/3] Input: synaptics - add multitouch multifinger support Chris Bagwell
2010-10-10 15:37 ` [PATCH 1/3] Input: synaptics - add multitouch support Chris Bagwell
2010-10-10 15:41 ` Chris Bagwell
2010-10-08 16:37 ` [PATCH 0/3] Input: synaptics - multitouch and multifinger support Takashi Iwai
2010-10-08 16:38 ` Takashi Iwai
2010-10-08 17:48 ` Takashi Iwai
2010-10-08 17:15 ` Chase Douglas
2010-10-08 17:46 ` Takashi Iwai
2010-10-08 18:04 ` Dmitry Torokhov
2010-10-08 19:31 ` Takashi Iwai
2010-10-10 21:04 ` Dmitry Torokhov
2010-10-11 7:35 ` Takashi Iwai
2010-10-11 7:48 ` Henrik Rydberg
2010-10-11 7:59 ` Takashi Iwai
2010-10-11 13:41 ` Chris Bagwell
2010-10-11 14:01 ` Takashi Iwai
2010-10-11 14:24 ` Henrik Rydberg
2010-10-11 14:49 ` Takashi Iwai
2010-10-11 15:31 ` Henrik Rydberg
2010-10-11 15:58 ` Takashi Iwai
2010-10-10 7:49 ` Henrik Rydberg
2010-10-10 20:59 ` Dmitry Torokhov
2010-10-11 7:28 ` Takashi Iwai
2010-10-11 7:40 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB1E2A4.4000000@cnpbagwell.com \
--to=chris@cnpbagwell.com \
--cc=apw@canonical.com \
--cc=chase.douglas@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=duncan.mcgreggor@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
--cc=rydberg@euromail.se \
--cc=tiwai@suse.de \
--cc=xorg-devel@lists.x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox