[PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

[PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/checkpatch.pl |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2039acd..6f8a1d4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1346,6 +1346,14 @@ sub process {
 			}
 		}
 
+		if ($rawline =~ /^ create mode (\d+) ([\w\.\/\-]+)$/) {
+			my $mode = $1;
+			my $file = $2;
+			if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
+				WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
+			}
+		}
+
 # Check for wrappage within a valid hunk of the file
 		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
 			ERROR("patch seems to be corrupt (line wrapped?)\n" .

Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

On Wed, Oct 06, 2010 at 04:31:31PM -0700, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  scripts/checkpatch.pl |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2039acd..6f8a1d4 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1346,6 +1346,14 @@ sub process {
>  			}
>  		}
>  
> +		if ($rawline =~ /^ create mode (\d+) ([\w\.\/\-]+)$/) {

Do you really need to escape ./- in the character-class? ISTR this is not
needed.

> +			my $mode = $1;
> +			my $file = $2;
> +			if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
> +				WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
> +			}

What about checking for no filename extension, too, and changing the message to
something like "use proper file permission or proper extension"?

> +		}
> +
>  # Check for wrappage within a valid hunk of the file
>  		if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
>  			ERROR("patch seems to be corrupt (line wrapped?)\n" .
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

[Michal Marek]

On 7.10.2010 08:54, Wolfram Sang wrote:
> On Wed, Oct 06, 2010 at 04:31:31PM -0700, Joe Perches wrote:
>> +			my $mode = $1;
>> +			my $file = $2;
>> +			if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
>> +				WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
>> +			}
> 
> What about checking for no filename extension, too, and changing the message to
> something like "use proper file permission or proper extension"?

That would result in too many false positives, I'm afraid. What about
checking for files with a shebang?

Michal

Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

[Rabin Vincent]

On Thu, Oct 7, 2010 at 5:01 AM, Joe Perches <joe@perches.com> wrote:
> +               if ($rawline =~ /^ create mode (\d+) ([\w\.\/\-]+)$/) {
> +                       my $mode = $1;
> +                       my $file = $2;
> +                       if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
> +                               WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
> +                       }
> +               }
> +

There's a vaguely similar patch already in -mm.  That one also handles mode
changes and doesn't require the presence of the diff summary.  Have a look in
case you missed it, maybe it does most of what you want and you can base
something on that:

http://userweb.kernel.org/~akpm/mmotm/broken-out/checkpatch-check-for-incorrect-permissions.patch