From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692Ab0JKTCI (ORCPT ); Mon, 11 Oct 2010 15:02:08 -0400 Received: from terminus.zytor.com ([198.137.202.10]:60067 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037Ab0JKTCF (ORCPT ); Mon, 11 Oct 2010 15:02:05 -0400 Message-ID: <4CB35EC1.5040909@zytor.com> Date: Mon, 11 Oct 2010 12:00:17 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Thunderbird/3.1.4 MIME-Version: 1.0 To: Yinghai Lu CC: Stephen Rothwell , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build warning after merge of the final tree (tip tree related) References: <20101011160429.81483d01.sfr@canb.auug.org.au> <4CB344C6.5040408@kernel.org> In-Reply-To: <4CB344C6.5040408@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2010 10:09 AM, Yinghai Lu wrote: > > make all functions in memblock.c without __init to carry __init_memblock. > > > -static phys_addr_t __init memblock_find_region(phys_addr_t start, phys_addr_t end, > +static phys_addr_t __init_memblock memblock_find_region(phys_addr_t start, phys_addr_t end, > phys_addr_t size, phys_addr_t align) > > -static int memblock_search(struct memblock_type *type, phys_addr_t addr) > +static int __init_memblock memblock_search(struct memblock_type *type, phys_addr_t addr) > Your patch description doesn't match what your patch does. Please write a correct description. -hpa