From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, setup: Check early serial console per string instead of one char
Date: Mon, 11 Oct 2010 12:56:15 -0700 [thread overview]
Message-ID: <4CB36BDF.5040200@zytor.com> (raw)
In-Reply-To: <4CB369E5.6040600@kernel.org>
On 10/11/2010 12:47 PM, Yinghai Lu wrote:
>>
>> This seems to add a bunch of code for zero benefit. Testing a global
>> variable is zero cost compared to either a BIOS call or poking a serial
>> port.
>
> some server have bios serial console redirection support, and bios int call could send char to screen and serial port.
>
> in that case, take out serial_putchar from putchar could produce more readable print out from serial console
>
That doesn't appear to have anything to do with this code change. What
you're saying is that "if BIOS does serial console redirection, we
shouldn't output to both the serial console and the BIOS console", which
is of course a truism, but that doesn't justify in any way this
particular code reconfiguration.
-hpa
prev parent reply other threads:[~2010-10-11 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 17:50 [PATCH] x86, setup: Check early serial console per string instead of one char Yinghai Lu
2010-10-11 18:19 ` H. Peter Anvin
2010-10-11 19:47 ` Yinghai Lu
2010-10-11 19:56 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB36BDF.5040200@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox