From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
scsi <linux-scsi@vger.kernel.org>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jing Huang <huangj@brocade.com>
Subject: Re: linux-next: Tree for October 12 (scsi/bfa)
Date: Tue, 12 Oct 2010 10:15:12 -0700 [thread overview]
Message-ID: <4CB497A0.6080307@oracle.com> (raw)
In-Reply-To: <20101012101414.045f62d5.randy.dunlap@oracle.com>
On 10/12/10 10:14, Randy Dunlap wrote:
> On Tue, 12 Oct 2010 16:35:52 +1100 Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20101011:
>
>
> bfa has one function that probably uses too much stack space and a few
> others that might be a problem.
>
> With CONFIG_FRAME_WARN=1024:
>
> drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 1024 bytes
BTW, these are on i386 builds.
> and with CONFIG_FRAME_WARN=512:
>
>
> drivers/scsi/bfa/bfad.c: In function 'bfad_fcs_port_cfg':
> drivers/scsi/bfa/bfad.c:900: warning: the frame size of 676 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfad_im.c: In function 'bfad_im_supported_speeds':
> drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfad_im.c: In function 'bfad_os_fc_host_init':
> drivers/scsi/bfa/bfad_im.c:976: warning: the frame size of 736 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_portattr_block':
> drivers/scsi/bfa/bfa_fcs_lport.c:2010: warning: the frame size of 572 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_rhba_pyld':
> drivers/scsi/bfa/bfa_fcs_lport.c:1803: warning: the frame size of 784 bytes is larger than 512 bytes
>
>
> Also, there are many comment blocks that begin with "/**", which means "beginning
> of kernel-doc comment block" for Linux kernel code. :(
>
> ---
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-10-12 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 5:35 linux-next: Tree for October 12 Stephen Rothwell
2010-10-12 17:14 ` linux-next: Tree for October 12 (scsi/bfa) Randy Dunlap
2010-10-12 17:15 ` Randy Dunlap [this message]
2010-10-12 22:44 ` Jing Huang
-- strict thread matches above, loose matches on Subject: below --
2010-10-12 22:55 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB497A0.6080307@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=huangj@brocade.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox