From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757928Ab0JLRQb (ORCPT ); Tue, 12 Oct 2010 13:16:31 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:48886 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757353Ab0JLRQ3 (ORCPT ); Tue, 12 Oct 2010 13:16:29 -0400 Message-ID: <4CB497A0.6080307@oracle.com> Date: Tue, 12 Oct 2010 10:15:12 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Stephen Rothwell , scsi CC: linux-next@vger.kernel.org, LKML , Jing Huang Subject: Re: linux-next: Tree for October 12 (scsi/bfa) References: <20101012163552.7306165b.sfr@canb.auug.org.au> <20101012101414.045f62d5.randy.dunlap@oracle.com> In-Reply-To: <20101012101414.045f62d5.randy.dunlap@oracle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/10 10:14, Randy Dunlap wrote: > On Tue, 12 Oct 2010 16:35:52 +1100 Stephen Rothwell wrote: > >> Hi all, >> >> Changes since 20101011: > > > bfa has one function that probably uses too much stack space and a few > others that might be a problem. > > With CONFIG_FRAME_WARN=1024: > > drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 1024 bytes BTW, these are on i386 builds. > and with CONFIG_FRAME_WARN=512: > > > drivers/scsi/bfa/bfad.c: In function 'bfad_fcs_port_cfg': > drivers/scsi/bfa/bfad.c:900: warning: the frame size of 676 bytes is larger than 512 bytes > drivers/scsi/bfa/bfad_im.c: In function 'bfad_im_supported_speeds': > drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 512 bytes > drivers/scsi/bfa/bfad_im.c: In function 'bfad_os_fc_host_init': > drivers/scsi/bfa/bfad_im.c:976: warning: the frame size of 736 bytes is larger than 512 bytes > drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_portattr_block': > drivers/scsi/bfa/bfa_fcs_lport.c:2010: warning: the frame size of 572 bytes is larger than 512 bytes > drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_rhba_pyld': > drivers/scsi/bfa/bfa_fcs_lport.c:1803: warning: the frame size of 784 bytes is larger than 512 bytes > > > Also, there are many comment blocks that begin with "/**", which means "beginning > of kernel-doc comment block" for Linux kernel code. :( > > --- -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***