* [PATCH 1/1] mfd: Add TPS658621C device ID
@ 2010-10-05 22:32 achew
2010-10-06 6:12 ` Mike Rapoport
0 siblings, 1 reply; 6+ messages in thread
From: achew @ 2010-10-05 22:32 UTC (permalink / raw)
To: mike, axel.lin, gking; +Cc: linux-kernel, Andrew Chew
From: Andrew Chew <achew@nvidia.com>
The interface for this device should be identical to that of the
TPS658521A.
Signed-off-by: Andrew Chew <achew@nvidia.com>
---
drivers/mfd/tps6586x.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index 117eb7c..b4931ab 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -47,6 +47,7 @@
/* device id */
#define TPS6586X_VERSIONCRC 0xcd
#define TPS658621A_VERSIONCRC 0x15
+#define TPS658621C_VERSIONCRC 0x2c
struct tps6586x_irq_data {
u8 mask_reg;
@@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
return -EIO;
}
- if (ret != TPS658621A_VERSIONCRC) {
+ if ((ret != TPS658621A_VERSIONCRC) &&
+ (ret != TPS658621C_VERSIONCRC)) {
dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
return -ENODEV;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: Add TPS658621C device ID
2010-10-05 22:32 achew
@ 2010-10-06 6:12 ` Mike Rapoport
2010-10-19 9:10 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2010-10-06 6:12 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: achew, axel.lin, gking, linux-kernel
Hi Samuel,
Can you please queue this?
achew@nvidia.com wrote:
> From: Andrew Chew <achew@nvidia.com>
>
> The interface for this device should be identical to that of the
> TPS658521A.
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
> ---
> drivers/mfd/tps6586x.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> index 117eb7c..b4931ab 100644
> --- a/drivers/mfd/tps6586x.c
> +++ b/drivers/mfd/tps6586x.c
> @@ -47,6 +47,7 @@
> /* device id */
> #define TPS6586X_VERSIONCRC 0xcd
> #define TPS658621A_VERSIONCRC 0x15
> +#define TPS658621C_VERSIONCRC 0x2c
>
> struct tps6586x_irq_data {
> u8 mask_reg;
> @@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
> return -EIO;
> }
>
> - if (ret != TPS658621A_VERSIONCRC) {
> + if ((ret != TPS658621A_VERSIONCRC) &&
> + (ret != TPS658621C_VERSIONCRC)) {
> dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
> return -ENODEV;
> }
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] mfd: Add TPS658621C device ID
@ 2010-10-12 21:24 Andrew Chew
2010-10-13 6:04 ` Mike Rapoport
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Chew @ 2010-10-12 21:24 UTC (permalink / raw)
To: mike@compulab.co.il, axel.lin@gmail.com, Gary King
Cc: linux-kernel@vger.kernel.org, Andrew Chew, 'Greg KH'
Sending again. Can someone review for commit?
This is a really simple change that adds a new valid device ID for the existing tps6586x PMU driver.
The interface for this device should be identical to that of the
TPS658521A.
Signed-off-by: Andrew Chew <achew@nvidia.com>
---
drivers/mfd/tps6586x.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index 117eb7c..b4931ab 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -47,6 +47,7 @@
/* device id */
#define TPS6586X_VERSIONCRC 0xcd
#define TPS658621A_VERSIONCRC 0x15
+#define TPS658621C_VERSIONCRC 0x2c
struct tps6586x_irq_data {
u8 mask_reg;
@@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
return -EIO;
}
- if (ret != TPS658621A_VERSIONCRC) {
+ if ((ret != TPS658621A_VERSIONCRC) &&
+ (ret != TPS658621C_VERSIONCRC)) {
dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
return -ENODEV;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: Add TPS658621C device ID
2010-10-12 21:24 [PATCH 1/1] mfd: Add TPS658621C device ID Andrew Chew
@ 2010-10-13 6:04 ` Mike Rapoport
2010-10-13 8:20 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2010-10-13 6:04 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Andrew Chew, axel.lin@gmail.com, Gary King,
linux-kernel@vger.kernel.org, 'Greg KH'
Samuel,
Can you please queue this?
Andrew Chew wrote:
> Sending again. Can someone review for commit?
>
> This is a really simple change that adds a new valid device ID for the existing tps6586x PMU driver.
>
> The interface for this device should be identical to that of the
> TPS658521A.
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
> ---
> drivers/mfd/tps6586x.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> index 117eb7c..b4931ab 100644
> --- a/drivers/mfd/tps6586x.c
> +++ b/drivers/mfd/tps6586x.c
> @@ -47,6 +47,7 @@
> /* device id */
> #define TPS6586X_VERSIONCRC 0xcd
> #define TPS658621A_VERSIONCRC 0x15
> +#define TPS658621C_VERSIONCRC 0x2c
>
> struct tps6586x_irq_data {
> u8 mask_reg;
> @@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
> return -EIO;
> }
>
> - if (ret != TPS658621A_VERSIONCRC) {
> + if ((ret != TPS658621A_VERSIONCRC) &&
> + (ret != TPS658621C_VERSIONCRC)) {
> dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
> return -ENODEV;
> }
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: Add TPS658621C device ID
2010-10-13 6:04 ` Mike Rapoport
@ 2010-10-13 8:20 ` Samuel Ortiz
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2010-10-13 8:20 UTC (permalink / raw)
To: Mike Rapoport
Cc: Andrew Chew, axel.lin@gmail.com, Gary King,
linux-kernel@vger.kernel.org, 'Greg KH'
Hi Mike,
On Wed, Oct 13, 2010 at 08:04:00AM +0200, Mike Rapoport wrote:
> Samuel,
>
> Can you please queue this?
Yes, I will.
Cheers,
Samuel.
>
> Andrew Chew wrote:
> >Sending again. Can someone review for commit?
> >
> >This is a really simple change that adds a new valid device ID for the existing tps6586x PMU driver.
> >
> >The interface for this device should be identical to that of the
> >TPS658521A.
> >
> >Signed-off-by: Andrew Chew <achew@nvidia.com>
>
> Acked-by: Mike Rapoport <mike@compulab.co.il>
>
> >---
> > drivers/mfd/tps6586x.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> >index 117eb7c..b4931ab 100644
> >--- a/drivers/mfd/tps6586x.c
> >+++ b/drivers/mfd/tps6586x.c
> >@@ -47,6 +47,7 @@
> > /* device id */
> > #define TPS6586X_VERSIONCRC 0xcd
> > #define TPS658621A_VERSIONCRC 0x15
> >+#define TPS658621C_VERSIONCRC 0x2c
> > struct tps6586x_irq_data {
> > u8 mask_reg;
> >@@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
> > return -EIO;
> > }
> >- if (ret != TPS658621A_VERSIONCRC) {
> >+ if ((ret != TPS658621A_VERSIONCRC) &&
> >+ (ret != TPS658621C_VERSIONCRC)) {
> > dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
> > return -ENODEV;
> > }
>
>
> --
> Sincerely yours,
> Mike.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: Add TPS658621C device ID
2010-10-06 6:12 ` Mike Rapoport
@ 2010-10-19 9:10 ` Samuel Ortiz
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2010-10-19 9:10 UTC (permalink / raw)
To: Mike Rapoport; +Cc: achew, axel.lin, gking, linux-kernel
Hi Mike, Andrew,
On Wed, Oct 06, 2010 at 08:12:23AM +0200, Mike Rapoport wrote:
> Hi Samuel,
>
> Can you please queue this?
>
Patch applied now, many thanks.
Cheers,
Samuel.
> achew@nvidia.com wrote:
> >From: Andrew Chew <achew@nvidia.com>
> >
> >The interface for this device should be identical to that of the
> >TPS658521A.
> >
> >Signed-off-by: Andrew Chew <achew@nvidia.com>
>
> Acked-by: Mike Rapoport <mike@compulab.co.il>
>
> >---
> > drivers/mfd/tps6586x.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> >index 117eb7c..b4931ab 100644
> >--- a/drivers/mfd/tps6586x.c
> >+++ b/drivers/mfd/tps6586x.c
> >@@ -47,6 +47,7 @@
> > /* device id */
> > #define TPS6586X_VERSIONCRC 0xcd
> > #define TPS658621A_VERSIONCRC 0x15
> >+#define TPS658621C_VERSIONCRC 0x2c
> > struct tps6586x_irq_data {
> > u8 mask_reg;
> >@@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
> > return -EIO;
> > }
> >- if (ret != TPS658621A_VERSIONCRC) {
> >+ if ((ret != TPS658621A_VERSIONCRC) &&
> >+ (ret != TPS658621C_VERSIONCRC)) {
> > dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
> > return -ENODEV;
> > }
>
>
> --
> Sincerely yours,
> Mike.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-19 9:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-12 21:24 [PATCH 1/1] mfd: Add TPS658621C device ID Andrew Chew
2010-10-13 6:04 ` Mike Rapoport
2010-10-13 8:20 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2010-10-05 22:32 achew
2010-10-06 6:12 ` Mike Rapoport
2010-10-19 9:10 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox