From: Tejun Heo <tj@kernel.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH unfinished update] firewire: sbp2: parallelize login/inquiry, reconnect, and shutdown
Date: Wed, 13 Oct 2010 11:45:38 +0200 [thread overview]
Message-ID: <4CB57FC2.9020509@kernel.org> (raw)
In-Reply-To: <4CB4EAA5.5010605@s5r6.in-berlin.de>
Hello,
On 10/13/2010 01:09 AM, Stefan Richter wrote:
> More extensive change but probably with simpler end result: Let
> sbp2_probe and sbp2_update perform login/scsi_add_device/reconnect
> directly. sbp2_probe and sbp2_update are serialized per node, but
> (since 2.6.36 with cmwq) parallelized across nodes.
I don't know much about firewire details but just in case it helps.
libata does the ATA part of probing in parallel using the async
mechanism (which is a wrapper around workqueue now) and executes the
SCSI probing in a serialized context. If SCSI parallel probing is
causing the problem, maybe firewire can do similar thing? The
difference between using async and workqueue directly is only in how
things can be ordered. There are cases where parallelizing probe is
easier with async but one way or the other it shouldn't matter too
much.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-10-13 9:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 14:55 [PATCH] firewire: core: use non-reentrant workqueue where necessary Stefan Richter
2010-10-10 14:57 ` [PATCH] firewire: sbp2: parallelize login/inquiry, reconnect, and shutdown Stefan Richter
2010-10-11 13:43 ` Tejun Heo
2010-10-11 21:27 ` Stefan Richter
2010-10-11 21:39 ` Stefan Richter
2010-10-12 13:55 ` Tejun Heo
2010-10-12 16:15 ` Stefan Richter
2010-10-12 16:46 ` Tejun Heo
2010-10-12 13:50 ` Tejun Heo
2010-10-12 21:39 ` [PATCH unfinished update] " Stefan Richter
2010-10-12 22:25 ` Stefan Richter
2010-10-12 23:09 ` Stefan Richter
2010-10-13 9:45 ` Tejun Heo [this message]
2010-10-11 13:29 ` [PATCH] firewire: core: use non-reentrant workqueue where necessary Tejun Heo
2010-10-11 19:05 ` Stefan Richter
2010-10-12 21:29 ` [PATCH update] firewire: core: use non-reentrant workqueue with rescuer Stefan Richter
2010-10-13 9:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB57FC2.9020509@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox