From: Tejun Heo <tj@kernel.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH update] firewire: core: use non-reentrant workqueue with rescuer
Date: Wed, 13 Oct 2010 11:47:12 +0200 [thread overview]
Message-ID: <4CB58020.6050707@kernel.org> (raw)
In-Reply-To: <tkrat.5d99b60dc100a6d0@s5r6.in-berlin.de>
Hello,
On 10/12/2010 11:29 PM, Stefan Richter wrote:
...
> fw_card.br_work instances should not, and instances of the others must
> not, be executed in parallel by multiple CPUs -- but were not protected
> against that. Hence allocated a non-reentrant workqueue for them.
>
> fw_device.work may be used in the memory reclaim path in case of SBP-2
> device updates. Hence we need a workqueue with rescuer and cannot use
> system_nrt_wq.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Looks good to me.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2010-10-13 9:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 14:55 [PATCH] firewire: core: use non-reentrant workqueue where necessary Stefan Richter
2010-10-10 14:57 ` [PATCH] firewire: sbp2: parallelize login/inquiry, reconnect, and shutdown Stefan Richter
2010-10-11 13:43 ` Tejun Heo
2010-10-11 21:27 ` Stefan Richter
2010-10-11 21:39 ` Stefan Richter
2010-10-12 13:55 ` Tejun Heo
2010-10-12 16:15 ` Stefan Richter
2010-10-12 16:46 ` Tejun Heo
2010-10-12 13:50 ` Tejun Heo
2010-10-12 21:39 ` [PATCH unfinished update] " Stefan Richter
2010-10-12 22:25 ` Stefan Richter
2010-10-12 23:09 ` Stefan Richter
2010-10-13 9:45 ` Tejun Heo
2010-10-11 13:29 ` [PATCH] firewire: core: use non-reentrant workqueue where necessary Tejun Heo
2010-10-11 19:05 ` Stefan Richter
2010-10-12 21:29 ` [PATCH update] firewire: core: use non-reentrant workqueue with rescuer Stefan Richter
2010-10-13 9:47 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB58020.6050707@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox