From: "H. Peter Anvin" <hpa@zytor.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Bob Picco <bpicco@redhat.com>,
Brian Bloniarz <phunge0@hotmail.com>,
Charles Butterfield <charles.butterfield@nextcentury.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-pci@vger.kernel.org,
"Horst H. von Brand" <vonbrand@inf.utfsm.cl>,
linux-kernel@vger.kernel.org, Stefan Becker <chemobejk@gmail.com>,
Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v3 4/6] x86/PCI: allocate space from the end of a region, not the beginning
Date: Wed, 13 Oct 2010 14:27:58 -0700 [thread overview]
Message-ID: <4CB6245E.8080007@zytor.com> (raw)
In-Reply-To: <20101013161526.28476.42395.stgit@bob.kio>
On 10/13/2010 09:15 AM, Bjorn Helgaas wrote:
>
> +#define ALIGN_DOWN(x, a) ((x) & ~(a - 1))
> - resource_size_t start = res->start;
> + resource_size_t start = ALIGN_DOWN(res->end - size + 1, align);
>
Use round_down() here instead of inventing yet another macro?
In all other respects:
Reviewed-by: H. Peter Anvin <hpa@linux.intel.com>
-hpa
next prev parent reply other threads:[~2010-10-13 21:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 16:15 [PATCH v3 0/6] PCI: allocate space top-down, not bottom-up Bjorn Helgaas
2010-10-13 16:15 ` [PATCH v3 1/6] resources: ensure alignment callback doesn't allocate below available start Bjorn Helgaas
2010-10-13 16:15 ` [PATCH v3 2/6] resources: allocate space within a region from the top down Bjorn Helgaas
[not found] ` <AANLkTinJqohDTjDLkBn84e9zn80opZss7kX_MPnoX4vd@mail.gmail.com>
2010-10-14 15:01 ` Bjorn Helgaas
2010-10-13 16:15 ` [PATCH v3 3/6] PCI: allocate bus resources " Bjorn Helgaas
2010-10-13 16:15 ` [PATCH v3 4/6] x86/PCI: allocate space from the end of a region, not the beginning Bjorn Helgaas
2010-10-13 21:27 ` H. Peter Anvin [this message]
2010-10-14 14:39 ` Bjorn Helgaas
2010-10-13 16:15 ` [PATCH v3 5/6] x86: update iomem_resource end based on CPU physical address capabilities Bjorn Helgaas
2010-10-13 16:15 ` [PATCH v3 6/6] x86: allocate space within a region top-down Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB6245E.8080007@zytor.com \
--to=hpa@zytor.com \
--cc=bjorn.helgaas@hp.com \
--cc=bpicco@redhat.com \
--cc=charles.butterfield@nextcentury.com \
--cc=chemobejk@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=phunge0@hotmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vonbrand@inf.utfsm.cl \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox