* [PATCH] scripts/package: don't break if %{_smp_mflags} isn't set
@ 2010-10-13 17:39 Nishanth Aravamudan
2010-10-13 22:02 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2010-10-13 17:39 UTC (permalink / raw)
To: nacc
Cc: jk, elendil, Michal Marek, Gilles Espinasse, Jiri Kosina,
John Saalwaechter, linux-kbuild, linux-kernel
Same fix as in 13797b77d419fc1b16eebf2993bf7b5cea65f0bf is needed for the "new"
line invoking _smp_mflags for modules_install. Without the fix, `make
binrpm-pkg` fails with:
+ make '%{_smp_mflags}' KBUILD_SRC= modules_install
make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
make[2]: *** No rule to make target `%{_smp_mflags}'. Stop.
error: Bad exit status from /var/tmp/rpm-tmp.8S9B9e (%install)
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
---
scripts/package/mkspec | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index 15440f5..e1c1d5b 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -70,7 +70,7 @@ echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
echo 'mkdir -p $RPM_BUILD_ROOT/lib/firmware'
echo "%endif"
-echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{_smp_mflags} KBUILD_SRC= modules_install'
+echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{?_smp_mflags} KBUILD_SRC= modules_install'
echo "%ifarch ia64"
echo 'cp $KBUILD_IMAGE $RPM_BUILD_ROOT'"/boot/efi/vmlinuz-$KERNELRELEASE"
echo 'ln -s '"efi/vmlinuz-$KERNELRELEASE" '$RPM_BUILD_ROOT'"/boot/"
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scripts/package: don't break if %{_smp_mflags} isn't set
2010-10-13 17:39 [PATCH] scripts/package: don't break if %{_smp_mflags} isn't set Nishanth Aravamudan
@ 2010-10-13 22:02 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2010-10-13 22:02 UTC (permalink / raw)
To: Nishanth Aravamudan
Cc: jk, elendil, Gilles Espinasse, Jiri Kosina, John Saalwaechter,
linux-kbuild, linux-kernel
On 13.10.2010 19:39, Nishanth Aravamudan wrote:
> Same fix as in 13797b77d419fc1b16eebf2993bf7b5cea65f0bf is needed for the "new"
> line invoking _smp_mflags for modules_install. Without the fix, `make
> binrpm-pkg` fails with:
>
> + make '%{_smp_mflags}' KBUILD_SRC= modules_install
> make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
> make[2]: *** No rule to make target `%{_smp_mflags}'. Stop.
> error: Bad exit status from /var/tmp/rpm-tmp.8S9B9e (%install)
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Thanks for the fix, applied to kbuild-2.6.git#packaging.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-13 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 17:39 [PATCH] scripts/package: don't break if %{_smp_mflags} isn't set Nishanth Aravamudan
2010-10-13 22:02 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox