From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638Ab0JMXHP (ORCPT ); Wed, 13 Oct 2010 19:07:15 -0400 Received: from claw.goop.org ([74.207.240.146]:54954 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471Ab0JMXHO (ORCPT ); Wed, 13 Oct 2010 19:07:14 -0400 Message-ID: <4CB63B9F.9060304@goop.org> Date: Wed, 13 Oct 2010 16:07:11 -0700 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 MIME-Version: 1.0 To: Yinghai Lu CC: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Benjamin Herrenschmidt , "linux-kernel@vger.kernel.org" , Vivek Goyal Subject: Re: [PATCH 0/4] memblock related fixes for -tip References: <4CAA4DC1.6000104@kernel.org> <4CB4ABE2.3010300@goop.org> <4CB4CF4D.5020706@kernel.org> <4CB4F11F.4090104@goop.org> <4CB54640.4000003@kernel.org> <4CB5DEE8.2020400@goop.org> <4CB5F86C.9030900@zytor.com> <4CB6107F.4080908@goop.org> <4CB62D54.7000400@kernel.org> In-Reply-To: <4CB62D54.7000400@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2010 03:06 PM, Yinghai Lu wrote: > On 10/13/2010 01:03 PM, Jeremy Fitzhardinge wrote: >>> a) Add an explicit interface to allocate bottoms-up, and have Xen use it >>> because it needs it. This is appropriate if (and only if) the >>> allocations in Xen aren't underneath a bunch of extra layers. >> The allocation is done in find_early_table_space() in x86/mm/init.c, so >> the allocation call itself can't be easily replaced, but I suppose some >> of the parameters could be global and tweaked by Xen code, but that's >> pretty ugly. > we already have > base = memblock_find_in_range(start, max_pfn_mapped< tables, PAGE_SIZE); > > so looks like xen have set max_pfn_mapped wrong? Hm, I'll double check. But the x86-64 code, at least, doesn't seem to care whether the allocated memory is mapped or not, since it does early_ioremap on each page before initializing it anyway. J