Re: [PATCH 0/4] memblock related fixes for -tip

Jeremy Fitzhardinge
2010-10-13T23:07:15Z

On 10/13/2010 03:06 PM, Yinghai Lu wrote:
> On 10/13/2010 01:03 PM, Jeremy Fitzhardinge wrote:
>>> a) Add an explicit interface to allocate bottoms-up, and have Xen use it
>>> because it needs it. This is appropriate if (and only if) the
>>> allocations in Xen aren't underneath a bunch of extra layers.
>> The allocation is done in find_early_table_space() in x86/mm/init.c, so
>> the allocation call itself can't be easily replaced, but I suppose some
>> of the parameters could be global and tweaked by Xen code, but that's
>> pretty ugly.
> we already have
> base = memblock_find_in_range(start, max_pfn_mapped<<PAGE_SHIFT,
> tables, PAGE_SIZE);
>
> so looks like xen have set max_pfn_mapped wrong?

Hm, I'll double check. But the x86-64 code, at least, doesn't seem to
care whether the allocated memory is mapped or not, since it does
early_ioremap on each page before initializing it anyway.

J