[PATCH -next] xfs: eliminate kconfig dependency warning

[PATCH -next] xfs: eliminate kconfig dependency warning

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 fs/xfs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20101013.orig/fs/xfs/Kconfig
+++ linux-next-20101013/fs/xfs/Kconfig
@@ -1,6 +1,6 @@
 config XFS_FS
 	tristate "XFS filesystem support"
-	depends on BLOCK
+	depends on BLOCK && NETWORK_FILESYSTEMS
 	select EXPORTFS
 	help
 	  XFS is a high performance journaling filesystem which originated

Re: [PATCH -next] xfs: eliminate kconfig dependency warning

[Dave Chinner]

On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kconfig dependency warning to satisfy dependencies:
> 
> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  fs/xfs/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20101013.orig/fs/xfs/Kconfig
> +++ linux-next-20101013/fs/xfs/Kconfig
> @@ -1,6 +1,6 @@
>  config XFS_FS
>  	tristate "XFS filesystem support"
> -	depends on BLOCK
> +	depends on BLOCK && NETWORK_FILESYSTEMS
>  	select EXPORTFS
>  	help
>  	  XFS is a high performance journaling filesystem which originated

This looks wrong to me.  IIUC, this means if you turn of network
filesystem support (e.g no NFS, CIFS, etc), you can't select XFS
even though it is a local filesystem.

EXPORTFS functionality actually has use for local filesystems - the
open-by-handle interfaces in XFS are what uses it, and there are patches
about that make this generic for most filesystems. Hence it seems to
me that the correct thing to do is separate EXPORTFS from
NETWORK_FILESYSTEMS, not make local filesystems depend on a user
selecting network filesystem support....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning

[Christoph Hellwig]

On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kconfig dependency warning to satisfy dependencies:
> 
> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

I'm not entirely sure what this gibberish means, but I'm pretty sure it
does not make sense.

EXPORTFS is a small module that doesn't have any dependencie, and it's
needed by XFS for the by-handle operation, and by nfsd for the same
thing.  It has absolutely nothing to do with networking or network
filesystems (as in network filesystem clients).

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning

[Randy Dunlap]

On 10/14/10 02:25, Christoph Hellwig wrote:
> On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix kconfig dependency warning to satisfy dependencies:
>>
>> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)
> 
> I'm not entirely sure what this gibberish means, but I'm pretty sure it
> does not make sense.
> 
> EXPORTFS is a small module that doesn't have any dependencie, and it's
> needed by XFS for the by-handle operation, and by nfsd for the same
> thing.  It has absolutely nothing to do with networking or network
> filesystems (as in network filesystem clients).
> 

Thanks, Dave and Christoph.  I'll look elsewhere for the glitch.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning

[Randy Dunlap]

On 10/14/10 02:25, Christoph Hellwig wrote:
> On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Fix kconfig dependency warning to satisfy dependencies:
>>
>> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)
> 
> I'm not entirely sure what this gibberish means, but I'm pretty sure it
> does not make sense.
> 
> EXPORTFS is a small module that doesn't have any dependencie, and it's
> needed by XFS for the by-handle operation, and by nfsd for the same
> thing.  It has absolutely nothing to do with networking or network
> filesystems (as in network filesystem clients).

The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu,
under the kconfig symbol NETWORK_FILESYSTEMS.

Dave Chinner wrote:
| EXPORTFS functionality actually has use for local filesystems - the
| open-by-handle interfaces in XFS are what uses it, and there are patches
| about that make this generic for most filesystems. Hence it seems to
| me that the correct thing to do is separate EXPORTFS from
| NETWORK_FILESYSTEMS, not make local filesystems depend on a user
| selecting network filesystem support....

Agreed.  Is that Kconfig change also part of the "patches about"?

thanks,
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning

[Dave Chinner]

On Thu, Oct 14, 2010 at 10:18:19AM -0700, Randy Dunlap wrote:
> On 10/14/10 02:25, Christoph Hellwig wrote:
> > On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> Fix kconfig dependency warning to satisfy dependencies:
> >>
> >> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)
> > 
> > I'm not entirely sure what this gibberish means, but I'm pretty sure it
> > does not make sense.
> > 
> > EXPORTFS is a small module that doesn't have any dependencie, and it's
> > needed by XFS for the by-handle operation, and by nfsd for the same
> > thing.  It has absolutely nothing to do with networking or network
> > filesystems (as in network filesystem clients).
> 
> The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu,
> under the kconfig symbol NETWORK_FILESYSTEMS.

Thanks for the explanation, Randy.

> Dave Chinner wrote:
> | EXPORTFS functionality actually has use for local filesystems - the
> | open-by-handle interfaces in XFS are what uses it, and there are patches
> | about that make this generic for most filesystems. Hence it seems to
> | me that the correct thing to do is separate EXPORTFS from
> | NETWORK_FILESYSTEMS, not make local filesystems depend on a user
> | selecting network filesystem support....
> 
> Agreed.  Is that Kconfig change also part of the "patches about"?

I can't remember exactly what it does with the kconfig symbols.
Information about the patch series (including a link to the git repo
storing the changes) is here:

http://marc.info/?l=linux-fsdevel&m=128627415827161&w=2

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning

[Randy Dunlap]

On 10/14/10 13:55, Dave Chinner wrote:
> On Thu, Oct 14, 2010 at 10:18:19AM -0700, Randy Dunlap wrote:
>> On 10/14/10 02:25, Christoph Hellwig wrote:
>>> On Wed, Oct 13, 2010 at 09:01:42PM -0700, Randy Dunlap wrote:
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> Fix kconfig dependency warning to satisfy dependencies:
>>>>
>>>> warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)
>>>
>>> I'm not entirely sure what this gibberish means, but I'm pretty sure it
>>> does not make sense.
>>>
>>> EXPORTFS is a small module that doesn't have any dependencie, and it's
>>> needed by XFS for the by-handle operation, and by nfsd for the same
>>> thing.  It has absolutely nothing to do with networking or network
>>> filesystems (as in network filesystem clients).
>>
>> The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu,
>> under the kconfig symbol NETWORK_FILESYSTEMS.
> 
> Thanks for the explanation, Randy.
> 
>> Dave Chinner wrote:
>> | EXPORTFS functionality actually has use for local filesystems - the
>> | open-by-handle interfaces in XFS are what uses it, and there are patches
>> | about that make this generic for most filesystems. Hence it seems to
>> | me that the correct thing to do is separate EXPORTFS from
>> | NETWORK_FILESYSTEMS, not make local filesystems depend on a user
>> | selecting network filesystem support....
>>
>> Agreed.  Is that Kconfig change also part of the "patches about"?
> 
> I can't remember exactly what it does with the kconfig symbols.
> Information about the patch series (including a link to the git repo
> storing the changes) is here:
> 
> http://marc.info/?l=linux-fsdevel&m=128627415827161&w=2

That patch series does not modify any Kconfig files.
That change can be done separately and at another time.

Thanks for the pointer.
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [xfs-masters] [PATCH -next] xfs: eliminate kconfig dependency warning

[Christoph Hellwig]

On Thu, Oct 14, 2010 at 10:18:19AM -0700, Randy Dunlap wrote:
> The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu,
> under the kconfig symbol NETWORK_FILESYSTEMS.

That's the culprit.  exportfs is just a helper library and should not
depend on anthing.  Looks like on of the various Kconfig patches broke
that.  Moving out of NETWORK_FILESYSTEMS will fix it.