From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755403Ab0JNQPh (ORCPT ); Thu, 14 Oct 2010 12:15:37 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:59623 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038Ab0JNQPg (ORCPT ); Thu, 14 Oct 2010 12:15:36 -0400 Message-ID: <4CB72C62.1030204@oracle.com> Date: Thu, 14 Oct 2010 09:14:26 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Johannes Berg CC: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , rpurdie@rpsys.net Subject: Re: mmotm 2010-10-13-17-13 uploaded (leds) References: <201010140044.o9E0iuR3029069@imap1.linux-foundation.org> <20101013212902.2fec6413.randy.dunlap@oracle.com> <1287056312.4641.296.camel@jlt3.sipsolutions.net> In-Reply-To: <1287056312.4641.296.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/10 04:38, Johannes Berg wrote: > On Thu, 2010-10-14 at 05:29 +0100, Randy Dunlap wrote: > >> When # CONFIG_LEDS_CLASS is not set >> & CONFIG_LEDS_TRIGGERS=y: >> >> drivers/built-in.o: In function `led_trigger_set': >> (.text+0x4737b): undefined reference to `led_brightness_set' > > Curious. Why is that even possible? > > config LEDS_CLASS > ... > if LEDS_CLASS > ... > config LEDS_TRIGGERS > ... > endif # LEDS_TRIGGERS > > endif # LEDS_CLASS > ... > > Are there dependencies missing? I was under the impression that this > shouldn't be happening. And what's the point in having triggers, but > nothing to trigger...? How about the patch below? It seems to be due to net/mac80211/Kconfig: config MAC80211_LEDS bool "Enable LED triggers" depends on MAC80211 select NEW_LEDS select LEDS_TRIGGERS > johannes > > > Subject: leds: fix up dependencies > From: Johannes Berg > > It's not useful to build LED triggers when > there's no LEDs that can be triggered by > them. Therefore, fix up the dependencies > so that this cannot happen, and fix a few > users that select triggers to depend on > LEDS_CLASS as well (there is also one user > that also selects LEDS_CLASS, which is OK). > > As a result, we can now make everything a > module again if desired (including the LED > triggers, that previously could only be > built in) -- and add back the warning in > rt2x00's Kconfig I previously removed. > > Reported-by: Randy Dunlap > Signed-off-by: Johannes Berg The patch does not apply cleanly to mmotm, but it seems like a good plan... -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***