From: Tejun Heo <tj@kernel.org>
To: lkml <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
Michal Hocko <mhocko@suse.cz>
Subject: [PATCH v2.6.36-rc7] memory_hotplug: drop spurious calls to flush_scheduled_work()
Date: Fri, 15 Oct 2010 17:25:15 +0200 [thread overview]
Message-ID: <4CB8725B.9010200@kernel.org> (raw)
lru_add_drain_all() uses schedule_on_each_cpu() which is synchronous.
There is no reason to call flush_scheduled_work() after
lru_add_drain_all(). Drop the spurious calls.
This is to prepare for the deprecation and removal of
flush_scheduled_work().
Signed-off-by: Tejun Heo <tj@kernel.org>
---
mm/memory_hotplug.c | 2 --
1 file changed, 2 deletions(-)
Index: work/mm/memory_hotplug.c
===================================================================
--- work.orig/mm/memory_hotplug.c
+++ work/mm/memory_hotplug.c
@@ -840,7 +840,6 @@ repeat:
ret = 0;
if (drain) {
lru_add_drain_all();
- flush_scheduled_work();
cond_resched();
drain_all_pages();
}
@@ -862,7 +861,6 @@ repeat:
}
/* drain all zone's lru pagevec, this is asyncronous... */
lru_add_drain_all();
- flush_scheduled_work();
yield();
/* drain pcp pages , this is synchrouns. */
drain_all_pages();
next reply other threads:[~2010-10-15 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 15:25 Tejun Heo [this message]
2010-10-18 0:01 ` [PATCH v2.6.36-rc7] memory_hotplug: drop spurious calls to flush_scheduled_work() KAMEZAWA Hiroyuki
2010-10-18 5:03 ` Tejun Heo
2010-10-18 23:58 ` KAMEZAWA Hiroyuki
2010-10-19 9:19 ` Tejun Heo
2010-10-18 5:23 ` Minchan Kim
2010-10-18 9:44 ` Mel Gorman
2010-10-19 4:38 ` KOSAKI Motohiro
2010-10-19 9:18 ` [PATCH wq#for-next] workqueue: Clarify that schedule_on_each_cpu is synchronous Tejun Heo
2010-10-20 0:20 ` KAMEZAWA Hiroyuki
2010-10-20 0:54 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB8725B.9010200@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).