[PATCH 01/05] Drivers: char: ip2: Makefile: replace the use of <module>-objs with <module>-y

[PATCH 01/05] Drivers: char: ip2: Makefile: replace the use of <module>-objs with <module>-y

[Tracey Dent]

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/char/ip2/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ip2/Makefile b/drivers/char/ip2/Makefile
index bc397d9..7b78e0d 100644
--- a/drivers/char/ip2/Makefile
+++ b/drivers/char/ip2/Makefile
@@ -4,5 +4,5 @@
 
 obj-$(CONFIG_COMPUTONE)         += ip2.o
 
-ip2-objs			:= ip2main.o
+ip2-y			:= ip2main.o
 
-- 
1.7.3.1.104.gc752e

[PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

[Tracey Dent]

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/char/ipmi/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
index eb8a1a8..16a9364 100644
--- a/drivers/char/ipmi/Makefile
+++ b/drivers/char/ipmi/Makefile
@@ -2,7 +2,7 @@
 # Makefile for the ipmi drivers.
 #
 
-ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
+ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
 
 obj-$(CONFIG_IPMI_HANDLER) += ipmi_msghandler.o
 obj-$(CONFIG_IPMI_DEVICE_INTERFACE) += ipmi_devintf.o
-- 
1.7.3.1.104.gc752e

Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

[Jiri Slaby]

On 10/16/2010 03:26 PM, Tracey Dent wrote:
> Changed <module>-objs to <module>-y in Makefile.
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
>  drivers/char/ipmi/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
> index eb8a1a8..16a9364 100644
> --- a/drivers/char/ipmi/Makefile
> +++ b/drivers/char/ipmi/Makefile
> @@ -2,7 +2,7 @@
>  # Makefile for the ipmi drivers.
>  #
>  
> -ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
> +ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o

NACK (and all of these). This will try to build 4 modules instead of
one. Read Documentation/kbuild/makefiles.txt

regards,
-- 
js

Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

[Jiri Slaby]

On 10/16/2010 06:52 PM, Jiri Slaby wrote:
> On 10/16/2010 03:26 PM, Tracey Dent wrote:
>> Changed <module>-objs to <module>-y in Makefile.
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>>  drivers/char/ipmi/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
>> index eb8a1a8..16a9364 100644
>> --- a/drivers/char/ipmi/Makefile
>> +++ b/drivers/char/ipmi/Makefile
>> @@ -2,7 +2,7 @@
>>  # Makefile for the ipmi drivers.
>>  #
>>  
>> -ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
>> +ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
> 
> NACK (and all of these). This will try to build 4 modules instead of
> one. Read Documentation/kbuild/makefiles.txt

Please disregard my NACK, I misread the patch.

regards,
-- 
js

Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

[Tracey Dent]

On 10/16/10, Jiri Slaby <jirislaby@gmail.com> wrote:
> On 10/16/2010 06:52 PM, Jiri Slaby wrote:
>> On 10/16/2010 03:26 PM, Tracey Dent wrote:
>>> Changed <module>-objs to <module>-y in Makefile.
>>>
>>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>>> ---
>>>  drivers/char/ipmi/Makefile |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
>>> index eb8a1a8..16a9364 100644
>>> --- a/drivers/char/ipmi/Makefile
>>> +++ b/drivers/char/ipmi/Makefile
>>> @@ -2,7 +2,7 @@
>>>  # Makefile for the ipmi drivers.
>>>  #
>>>
>>> -ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
>>> +ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
>>
>> NACK (and all of these). This will try to build 4 modules instead of
>> one. Read Documentation/kbuild/makefiles.txt
>
> Please disregard my NACK, I misread the patch.
>

Okay, no problem. So instead of getting your NACK does it get a ACK by you?

> regards,
> --
> js
>

Thanks,

Tracey D

[PATCH 03/05] Drivers: Char: mwave: Makefile: Makefile clean up

[Tracey Dent]

Changed <module>-objs to <module>-y in Makefile and use
ccflags-y option.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/char/mwave/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/mwave/Makefile b/drivers/char/mwave/Makefile
index 754c9e2..26b4fce 100644
--- a/drivers/char/mwave/Makefile
+++ b/drivers/char/mwave/Makefile
@@ -6,10 +6,10 @@
 
 obj-$(CONFIG_MWAVE) += mwave.o
 
-mwave-objs := mwavedd.o smapi.o tp3780i.o 3780i.o
+mwave-y := mwavedd.o smapi.o tp3780i.o 3780i.o
 
 # To have the mwave driver disable other uarts if necessary
 # EXTRA_CFLAGS += -DMWAVE_FUTZ_WITH_OTHER_DEVICES
 
 # To compile in lots (~20 KiB) of run-time enablable printk()s for debugging:
-EXTRA_CFLAGS += -DMW_TRACE
+ccflags-y := -DMW_TRACE
-- 
1.7.3.1.104.gc752e

[PATCH 04/05] Drivers: char: pcmcia: ipwireless: Makefile: replace the use of <module>-objs with <module>-y

[Tracey Dent]

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/char/pcmcia/ipwireless/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/pcmcia/ipwireless/Makefile b/drivers/char/pcmcia/ipwireless/Makefile
index b71eb59..db80873 100644
--- a/drivers/char/pcmcia/ipwireless/Makefile
+++ b/drivers/char/pcmcia/ipwireless/Makefile
@@ -6,5 +6,5 @@
 
 obj-$(CONFIG_IPWIRELESS) += ipwireless.o
 
-ipwireless-objs := hardware.o main.o network.o tty.o
+ipwireless-y := hardware.o main.o network.o tty.o
 
-- 
1.7.3.1.104.gc752e

[PATCH 05/05] Drivers: char: rio: Makefile: replace the use of <module>-objs with <module>-y

[Tracey Dent]

Changed <module>-objs to <module>-y in Makefile.

Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
 drivers/char/rio/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/rio/Makefile b/drivers/char/rio/Makefile
index 2d1c5a7..1661875 100644
--- a/drivers/char/rio/Makefile
+++ b/drivers/char/rio/Makefile
@@ -8,5 +8,5 @@
 
 obj-$(CONFIG_RIO) += rio.o
 
-rio-objs := rio_linux.o rioinit.o rioboot.o riocmd.o rioctrl.o riointr.o \
+rio-y := rio_linux.o rioinit.o rioboot.o riocmd.o rioctrl.o riointr.o \
             rioparam.o rioroute.o riotable.o riotty.o
-- 
1.7.3.1.104.gc752e