From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791Ab0JRFEQ (ORCPT ); Mon, 18 Oct 2010 01:04:16 -0400 Received: from hera.kernel.org ([140.211.167.34]:49702 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840Ab0JRFEP (ORCPT ); Mon, 18 Oct 2010 01:04:15 -0400 Message-ID: <4CBBD529.8060600@kernel.org> Date: Mon, 18 Oct 2010 07:03:37 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.9) Gecko/20100915 Lightning/1.0b2 Thunderbird/3.1.4 MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: lkml , Andrew Morton , Mel Gorman , Wu Fengguang , Michal Hocko Subject: Re: [PATCH v2.6.36-rc7] memory_hotplug: drop spurious calls to flush_scheduled_work() References: <4CB8725B.9010200@kernel.org> <20101018090123.5afe4abf.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20101018090123.5afe4abf.kamezawa.hiroyu@jp.fujitsu.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Mon, 18 Oct 2010 05:03:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/18/2010 02:01 AM, KAMEZAWA Hiroyuki wrote: > On Fri, 15 Oct 2010 17:25:15 +0200 > Tejun Heo wrote: > >> lru_add_drain_all() uses schedule_on_each_cpu() which is synchronous. >> There is no reason to call flush_scheduled_work() after >> lru_add_drain_all(). Drop the spurious calls. >> >> This is to prepare for the deprecation and removal of >> flush_scheduled_work(). >> >> Signed-off-by: Tejun Heo > Acked-by: KAMEZAWA Hiroyuki Through which tree should this be routed? Shall I route this via the wq tree? Thank you. -- tejun