Re: [PATCH v5] blk: fix a wrong accounting of hd_struct->in_flight

Jens Axboe
2010-10-19T10:02:20Z

On 2010-10-19 04:22, Yasuaki Ishimatsu wrote:
> Hi Jens,
>
>> This version looks good, thanks for following through on this. What kind
>> of testing did you do?
>
> I did three kinds of test.
>
> 1. run a reproducer.
> I confirmed the problem was fixed using attached the reproducer.
>
> 2. remove and make a partition which is running I/O.
> I confirmed the kernel panic or hungup did not occur using following steps.
>
> # dd if=/dev/sda of=null &
> # while true
> > do
> > /sbin/parted /dev/sda rm 3 > /dev/null
> > /sbin/parted /dev/sda mkpart primary ext2 42.5GB 52.5GB > /dev/null
> > sleep 2
> > done
>
> 3. reload a partition which is running I/O.
> I confirmed the kernel panic or hungup did not occur using following steps.
>
> # dd if=/dev/sda of=null &
> # while true
> > do
> > /sbin/hdparm -z /dev/sda
> > sleep 2
> > done

Thanks, sounds good! I have queued it up for 2.6.37 and marked as a
stable backport candidate.

--
Jens Axboe