From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756141Ab0JROWr (ORCPT ); Mon, 18 Oct 2010 10:22:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27701 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754967Ab0JROWq (ORCPT ); Mon, 18 Oct 2010 10:22:46 -0400 Message-ID: <4CBC5825.8050502@redhat.com> Date: Mon, 18 Oct 2010 09:22:29 -0500 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Namhyung Kim CC: Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate() References: <1287140582-5925-1-git-send-email-namhyung@gmail.com> In-Reply-To: <1287140582-5925-1-git-send-email-namhyung@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Namhyung Kim wrote: > Signed-off-by: Namhyung Kim > --- > fs/ext3/inode.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c > index 5e0faf4..90a9c3d 100644 > --- a/fs/ext3/inode.c > +++ b/fs/ext3/inode.c > @@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode) > */ > } else { > /* Shared branch grows from an indirect block */ > - BUFFER_TRACE(partial->bh, "get_write_access"); > ext3_free_branches(handle, inode, partial->bh, > partial->p, > partial->p+1, (chain+n-1) - partial); As long as you're doing these cleanups, you may as well eyeball ext4 to see whether the same issues exist; in the case above, it does, and the exact same patch (modulo ext3/ext4 changes) applies. No real point in getting ext3 fixed up and leaving ext4 behind... Thanks, -Eric