From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86, irq: Check if irq is remapped before freeing irte
Date: Mon, 18 Oct 2010 13:47:48 -0700 [thread overview]
Message-ID: <4CBCB274.7010108@kernel.org> (raw)
On one system that support intr-rempping when boot with "intremap=off"
got:
[ 177.824202] calling alsa_card_azx_init+0x0/0x1b @ 1
[ 177.843968] HDA Intel 0000:00:1b.0: PCI INT A -> GSI 22 (level, low) -> IRQ 22
[ 177.848210] HDA Intel 0000:00:1b.0: irq 1435 for MSI/MSI-X
[ 177.863797] HDA Intel 0000:00:1b.0: setting latency timer to 64
[ 177.895084] hda-intel: no codecs found!
[ 177.895501] BUG: unable to handle kernel NULL pointer dereference at 00000000000000f8
[ 177.913316] IP: [<ffffffff8145fc18>] free_irte+0x47/0xc0
[ 177.913859] PGD 0
[ 177.914037] Oops: 0000 [#1] SMP
[ 177.933240] last sysfs file:
[ 177.933501] CPU 0
[ 177.933655] Modules linked in:
[ 177.933937]
[ 177.934078] Pid: 15044, comm: work_for_cpu Not tainted 2.6.36-rc8-tip-yh-01994-g95100d0-dirty #198 /Sun Fire X4800
[ 177.953986] RIP: 0010:[<ffffffff8145fc18>] [<ffffffff8145fc18>] free_irte+0x47/0xc0
...
[ 178.173326] Call Trace:
[ 178.173574] [<ffffffff810515b4>] destroy_irq+0x3a/0x75
[ 178.192934] [<ffffffff81051834>] arch_teardown_msi_irq+0xe/0x10
[ 178.193418] [<ffffffff81458dc3>] arch_teardown_msi_irqs+0x56/0x7f
[ 178.213021] [<ffffffff81458e79>] free_msi_irqs+0x8d/0xeb
[ 178.213490] [<ffffffff81459673>] pci_disable_msi+0x35/0x3a
[ 178.232956] [<ffffffff81b68917>] azx_free+0x83/0x11c
[ 178.233301] [<ffffffff81cb1ec7>] azx_probe+0x7b1/0xab4
[ 178.252885] [<ffffffff810a59ef>] ? trace_hardirqs_on+0xd/0xf
[ 178.253303] [<ffffffff81442a50>] local_pci_probe+0x4d/0x96
[ 178.272801] [<ffffffff8108e72c>] ? do_work_for_cpu+0x0/0x2b
[ 178.273270] [<ffffffff8108e744>] do_work_for_cpu+0x18/0x2b
[ 178.292785] [<ffffffff8108e72c>] ? do_work_for_cpu+0x0/0x2b
[ 178.293220] [<ffffffff81094135>] kthread+0x9d/0xa5
[ 178.312742] [<ffffffff81034954>] kernel_thread_helper+0x4/0x10
[ 178.313222] [<ffffffff81cc96fc>] ? restore_args+0x0/0x30
[ 178.332746] [<ffffffff81094098>] ? kthread+0x0/0xa5
[ 178.333207] [<ffffffff81034950>] ? kernel_thread_helper+0x0/0x10
Root cause is that irq_2_iommu is embedded into irq_cfg now...
Need to check if that irq is really mapped, before free irte.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/intr_remapping.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/intr_remapping.c
===================================================================
--- linux-2.6.orig/drivers/pci/intr_remapping.c
+++ linux-2.6/drivers/pci/intr_remapping.c
@@ -60,7 +60,7 @@ int get_irte(int irq, struct irte *entry
unsigned long flags;
int index;
- if (!entry || !irq_iommu)
+ if (!entry || !irq_iommu || !irq_iommu->iommu)
return -1;
spin_lock_irqsave(&irq_2_ir_lock, flags);
@@ -268,7 +268,7 @@ int free_irte(int irq)
unsigned long flags;
int rc;
- if (!irq_iommu)
+ if (!irq_iommu || !irq_iommu->iommu)
return -1;
spin_lock_irqsave(&irq_2_ir_lock, flags);
next reply other threads:[~2010-10-18 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 20:47 Yinghai Lu [this message]
2010-10-18 21:09 ` [PATCH] x86, irq: Check if irq is remapped before freeing irte Thomas Gleixner
2010-10-18 21:17 ` Thomas Gleixner
2010-10-18 21:28 ` Yinghai
2010-10-18 22:22 ` Yinghai Lu
2010-10-18 22:31 ` Thomas Gleixner
2010-10-18 22:47 ` Yinghai Lu
2010-10-19 7:28 ` [tip:irq/core] x86: ioapic: Call free_irte only if interrupt remapping enabled tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBCB274.7010108@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox