From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754807Ab0JSQPn (ORCPT ); Tue, 19 Oct 2010 12:15:43 -0400 Received: from hera.kernel.org ([140.211.167.34]:33164 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802Ab0JSQPm (ORCPT ); Tue, 19 Oct 2010 12:15:42 -0400 Message-ID: <4CBDC419.8060909@kernel.org> Date: Tue, 19 Oct 2010 18:15:21 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.9) Gecko/20100915 Lightning/1.0b2 Thunderbird/3.1.4 MIME-Version: 1.0 To: Jeff Layton CC: Steve French , linux-cifs@vger.kernel.org, lkml Subject: Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync() References: <4CBDBF8A.8010106@kernel.org> <20101019121319.16f06b76@corrin.poochiereds.net> In-Reply-To: <20101019121319.16f06b76@corrin.poochiereds.net> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Tue, 19 Oct 2010 16:15:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/19/2010 06:13 PM, Jeff Layton wrote: > On Tue, 19 Oct 2010 17:55:54 +0200 > Tejun Heo wrote: > >> flush_scheduled_work() is going away. >> >> Signed-off-by: Tejun Heo >> --- >> fs/cifs/cifs_dfs_ref.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> Index: work/fs/cifs/cifs_dfs_ref.c >> =================================================================== >> --- work.orig/fs/cifs/cifs_dfs_ref.c >> +++ work/fs/cifs/cifs_dfs_ref.c >> @@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s >> void cifs_dfs_release_automount_timer(void) >> { >> BUG_ON(!list_empty(&cifs_dfs_automount_list)); >> - cancel_delayed_work(&cifs_dfs_automount_task); >> - flush_scheduled_work(); >> + cancel_delayed_work_sync(&cifs_dfs_automount_task); >> } >> >> /** > > Looks like a better way to do this anyhow. > > Reviewed-by: Jeff Layton Yeah, way faster too. It would be best to route this patch through cifs tree but I can push it through wq tree too. Just let me know. Thanks. -- tejun