* [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync()
@ 2010-10-19 15:55 Tejun Heo
2010-10-19 16:13 ` Jeff Layton
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2010-10-19 15:55 UTC (permalink / raw)
To: Steve French, linux-cifs, lkml
flush_scheduled_work() is going away.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
fs/cifs/cifs_dfs_ref.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: work/fs/cifs/cifs_dfs_ref.c
===================================================================
--- work.orig/fs/cifs/cifs_dfs_ref.c
+++ work/fs/cifs/cifs_dfs_ref.c
@@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s
void cifs_dfs_release_automount_timer(void)
{
BUG_ON(!list_empty(&cifs_dfs_automount_list));
- cancel_delayed_work(&cifs_dfs_automount_task);
- flush_scheduled_work();
+ cancel_delayed_work_sync(&cifs_dfs_automount_task);
}
/**
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync()
2010-10-19 15:55 [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync() Tejun Heo
@ 2010-10-19 16:13 ` Jeff Layton
2010-10-19 16:15 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2010-10-19 16:13 UTC (permalink / raw)
To: Tejun Heo; +Cc: Steve French, linux-cifs, lkml
On Tue, 19 Oct 2010 17:55:54 +0200
Tejun Heo <tj@kernel.org> wrote:
> flush_scheduled_work() is going away.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> fs/cifs/cifs_dfs_ref.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: work/fs/cifs/cifs_dfs_ref.c
> ===================================================================
> --- work.orig/fs/cifs/cifs_dfs_ref.c
> +++ work/fs/cifs/cifs_dfs_ref.c
> @@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s
> void cifs_dfs_release_automount_timer(void)
> {
> BUG_ON(!list_empty(&cifs_dfs_automount_list));
> - cancel_delayed_work(&cifs_dfs_automount_task);
> - flush_scheduled_work();
> + cancel_delayed_work_sync(&cifs_dfs_automount_task);
> }
>
> /**
Looks like a better way to do this anyhow.
Reviewed-by: Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync()
2010-10-19 16:13 ` Jeff Layton
@ 2010-10-19 16:15 ` Tejun Heo
2010-10-19 18:22 ` Steve French
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2010-10-19 16:15 UTC (permalink / raw)
To: Jeff Layton; +Cc: Steve French, linux-cifs, lkml
Hello,
On 10/19/2010 06:13 PM, Jeff Layton wrote:
> On Tue, 19 Oct 2010 17:55:54 +0200
> Tejun Heo <tj@kernel.org> wrote:
>
>> flush_scheduled_work() is going away.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> ---
>> fs/cifs/cifs_dfs_ref.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> Index: work/fs/cifs/cifs_dfs_ref.c
>> ===================================================================
>> --- work.orig/fs/cifs/cifs_dfs_ref.c
>> +++ work/fs/cifs/cifs_dfs_ref.c
>> @@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s
>> void cifs_dfs_release_automount_timer(void)
>> {
>> BUG_ON(!list_empty(&cifs_dfs_automount_list));
>> - cancel_delayed_work(&cifs_dfs_automount_task);
>> - flush_scheduled_work();
>> + cancel_delayed_work_sync(&cifs_dfs_automount_task);
>> }
>>
>> /**
>
> Looks like a better way to do this anyhow.
>
> Reviewed-by: Jeff Layton <jlayton@redhat.com>
Yeah, way faster too. It would be best to route this patch through
cifs tree but I can push it through wq tree too. Just let me know.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync()
2010-10-19 16:15 ` Tejun Heo
@ 2010-10-19 18:22 ` Steve French
0 siblings, 0 replies; 4+ messages in thread
From: Steve French @ 2010-10-19 18:22 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jeff Layton, Steve French, linux-cifs, lkml
OK - will add this to the cifs tree this afternoon.
On Tue, Oct 19, 2010 at 11:15 AM, Tejun Heo <tj@kernel.org> wrote:
> Hello,
>
> On 10/19/2010 06:13 PM, Jeff Layton wrote:
>> On Tue, 19 Oct 2010 17:55:54 +0200
>> Tejun Heo <tj@kernel.org> wrote:
>>
>>> flush_scheduled_work() is going away.
>>>
>>> Signed-off-by: Tejun Heo <tj@kernel.org>
>>> ---
>>> fs/cifs/cifs_dfs_ref.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> Index: work/fs/cifs/cifs_dfs_ref.c
>>> ===================================================================
>>> --- work.orig/fs/cifs/cifs_dfs_ref.c
>>> +++ work/fs/cifs/cifs_dfs_ref.c
>>> @@ -44,8 +44,7 @@ static void cifs_dfs_expire_automounts(s
>>> void cifs_dfs_release_automount_timer(void)
>>> {
>>> BUG_ON(!list_empty(&cifs_dfs_automount_list));
>>> - cancel_delayed_work(&cifs_dfs_automount_task);
>>> - flush_scheduled_work();
>>> + cancel_delayed_work_sync(&cifs_dfs_automount_task);
>>> }
>>>
>>> /**
>>
>> Looks like a better way to do this anyhow.
>>
>> Reviewed-by: Jeff Layton <jlayton@redhat.com>
>
> Yeah, way faster too. It would be best to route this patch through
> cifs tree but I can push it through wq tree too. Just let me know.
>
> Thanks.
>
> --
> tejun
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-19 18:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-19 15:55 [PATCH v2.6.36-rc7] cifs: cancel_delayed_work() + flush_scheduled_work() -> cancel_delayed_work_sync() Tejun Heo
2010-10-19 16:13 ` Jeff Layton
2010-10-19 16:15 ` Tejun Heo
2010-10-19 18:22 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox