Re: linux-next: manual merge of the staging-next tree with the v4l-dvb tree

Mauro Carvalho Chehab
2010-04-28T19:06:52Z

Greg KH wrote:
> On Wed, Apr 28, 2010 at 04:07:49PM +1000, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> Today's linux-next merge of the staging-next tree got a conflict in
>> drivers/staging/cx25821/cx25821-alsa.c between commit
>> 4e0c923a0d23f86c7331b32bc2aeb280e10e029e ("V4L/DVB: Staging: cx25821: fix
>> coding style issues in cx25821-alsa.c") from the v4l-dvb tree and commit
>> 98a178beaaf4c9a0acc4815807be51425b91f0a7 ("Staging: cx25821 fixed C99
>> comments, white spaces and unnecessary braces") from the staging-next
>> tree.
>>
>> I used the v4l-dvb versions of the conflicting bits (they looked neater
>> to me).
>
> Odd, Mauro, why are you applying coding style fixes to the staging tree
> to your tree? I'll be glad to take them instead.

This driver (cx25821) came from my tree, so I was just keep maintaining it.
Although the driver works fine, it has some coding style issues, but the biggest
issue is that it has the same code that is almost identical replicated 8
times (one for each simultaneous stream that the device supports), and another
code duplicated 4 times (for the 4 simultaneous output streams).

Sorry, but I didn't realized that you're also retrieving patches for it. I think
I just assumed that we're following the same procedure as agreed with relation
to go7007 driver.

Anyway, the driver maintainer is now preparing a changeset that will hopefully
solve the remaining issues that prevented it to be added directly on /drivers/media.

Cheers,
Mauro