From: Micha Nelissen <micha@neli.hopto.org>
To: Alexandre Bounine <alexandre.bounine@idt.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
Matt Porter <mporter@kernel.crashing.org>,
Li Yang <leoli@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>,
Thomas Moll <thomas.moll@sysgo.com>
Subject: Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches
Date: Thu, 21 Oct 2010 23:15:32 +0200 [thread overview]
Message-ID: <4CC0AD74.8070800@neli.hopto.org> (raw)
In-Reply-To: <1287688250-14226-1-git-send-email-alexandre.bounine@idt.com>
Alexandre Bounine wrote:
> 1. Using one storage location common for switches and endpoints eliminates
> unnecessary device type checks during maintenance access operations.
> While destination IDs and hop counts have different meaning for endpoints and
> switches, this does not prevent us from storing them in the primary RIO device
> structure (rio_dev) for both types.
How can you say this? The two variables have different meanings, this
logically implies you can't merge them. So how do you say 'this does not
prevent us from ...' without providing a reason?
> 2. Convert RIO switch device structures (rio_dev + rio_switch) into single
> allocation unit. This change is based on the fact that RIO switches are using
> common RIO device objects anyway. Allocating RIO switch objects as RIO devices
> with added space for switch information simplifies handling of RIO switch device
> objects.
I still don't think that's a good idea because the rdev->rswitch pointer
can be defined to point to the switch that a given rio_dev is connected
to. This is useful for quick lookups. How else can to know to which
switch a given device is connected?
Micha
next prev parent reply other threads:[~2010-10-21 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 19:10 [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches Alexandre Bounine
2010-10-21 19:10 ` [PATCH -mm 1/2] RapidIO: Use common destid storage for endpoints and switches Alexandre Bounine
2010-10-21 19:10 ` [PATCH -mm 2/2] RapidIO: Integrate rio_switch into rio_dev Alexandre Bounine
2010-10-21 21:15 ` Micha Nelissen [this message]
2010-10-22 16:47 ` [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches Bounine, Alexandre
2010-10-22 18:28 ` Micha Nelissen
2010-10-22 21:04 ` Bounine, Alexandre
2010-10-22 21:58 ` Micha Nelissen
2010-10-25 13:22 ` Bounine, Alexandre
2010-10-25 16:13 ` Micha Nelissen
2010-10-25 17:13 ` Bounine, Alexandre
2010-10-25 20:06 ` Micha Nelissen
2010-10-26 13:39 ` Bounine, Alexandre
2010-10-26 14:22 ` Micha Nelissen
2010-10-26 17:17 ` Bounine, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC0AD74.8070800@neli.hopto.org \
--to=micha@neli.hopto.org \
--cc=akpm@linux-foundation.org \
--cc=alexandre.bounine@idt.com \
--cc=galak@kernel.crashing.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mporter@kernel.crashing.org \
--cc=thomas.moll@sysgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox