From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759604Ab0JVVXU (ORCPT ); Fri, 22 Oct 2010 17:23:20 -0400 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:60073 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756900Ab0JVVXT (ORCPT ); Fri, 22 Oct 2010 17:23:19 -0400 X-Sasl-enc: 4Vkw9TJsOxYwOvrvYO8rKUy7B5+Y6JkTv2jO4J7Baanq 1287782598 Message-ID: <4CC200C3.8000208@fastmail.fm> Date: Fri, 22 Oct 2010 22:23:15 +0100 From: Jack Stone User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.2.11) Gecko/20101013 Lightning/1.0b2 Thunderbird/3.1.5 MIME-Version: 1.0 To: Ben Hutchings CC: Greg KH , linux-kernel@vger.kernel.org, stable@kernel.org, Florian Fainelli , stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, 600155@bugs.debian.org, Jason Heeris , David Miller , spamalot@hispeed.ch Subject: Re: [11/17] r6040: Fix multicast list iteration when hash filter is used References: <20101022184033.486292826@clark.site> <4CC1E257.4070704@fastmail.fm> <20101022192350.GA10673@suse.de> <4CC1E610.4050605@fastmail.fm> <1287782286.20865.248.camel@localhost> In-Reply-To: <1287782286.20865.248.camel@localhost> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/10/2010 22:18, Ben Hutchings wrote: > On Fri, 2010-10-22 at 20:29 +0100, Jack Stone wrote: >> On 22/10/2010 20:23, Greg KH wrote: >>> On Fri, Oct 22, 2010 at 08:13:27PM +0100, Jack Stone wrote: >>>> On 22/10/2010 19:39, Greg KH wrote: >>>>> drivers/net/r6040.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> --- a/drivers/net/r6040.c >>>>> +++ b/drivers/net/r6040.c >>>>> @@ -976,6 +976,7 @@ static void r6040_multicast_list(struct >>>>> iowrite16(hash_table[3], ioaddr + MAR3); >>>>> } >>>>> /* Multicast Address 1~4 case */ >>>>> + dmi = dev->mc_list; >>>>> for (i = 0, dmi; (i < dev->mc_count) && (i < MCAST_MAX); i++) { >>>> Any reason for the dmi in the above line? As far as I can see it is a >>>> nop. >>> >>> Look closer at the for loop please. >> >> Maybe I'm missing something but: >> for (i = 0, ---->dmi <----; (i < ... >> >> The dmi here still doesn't seem to do anything? > > It doesn't, but it doesn't do any harm either. The loop has been > rewritten in mainline. Agreed, it causes no problems, but it seems like it was intended to be the dmi init, i.e. for (i = 0, dmi = dev->mc_list; ... I suppose it doesn't really matter but either removing the dmi in the for loop or moving the dmi init in there would make more sense to me. I really should learn to explain myself fully. Sorry for taking up your time. Thanks, Jack