[PATCH] firewire: nosy: char device is not seekable

Stefan Richter
2010-10-13T12:26:05Z

Amend .open handler accordingly and add .llseek = no_llseek handler.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Arnd, is your mega-patch which adds legions of .llseek handlers done and
to be merged soon as-is, or do you regenerate it regularly? (linux-next
commit 9711569d "llseek: automatically add .llseek fop")

drivers/firewire/nosy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/drivers/firewire/nosy.c
===================================================================
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -302,7 +302,7 @@ nosy_open(struct inode *inode, struct fi

file->private_data = client;

- return 0;
+ return nonseekable_open(inode, file);
fail:
kfree(client);
lynx_put(lynx);
@@ -400,6 +400,7 @@ nosy_ioctl(struct file *file, unsigned i

static const struct file_operations nosy_ops = {
.owner = THIS_MODULE,
+ .llseek = no_llseek,
.read = nosy_read,
.unlocked_ioctl = nosy_ioctl,
.poll = nosy_poll,

--
Stefan Richter
-=====-==-=- =-=- -==-=