From: Marc Kleine-Budde <mkl@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: masa-korg@dsn.okisemi.com, andrew.chih.howe.khor@intel.com,
sameo@linux.intel.com, margie.foster@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
socketcan-core@lists.berlios.de, kok.howg.ewe@intel.com,
wg@grandegger.com, morinaga526@dsn.okisemi.com,
joel.clark@intel.com, yong.y.wang@intel.com, chripell@fsfe.org,
qi.wang@intel.com
Subject: Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
Date: Mon, 25 Oct 2010 00:05:25 +0200 [thread overview]
Message-ID: <4CC4ADA5.8@pengutronix.de> (raw)
In-Reply-To: <20101024.144312.104048720.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
On 10/24/2010 11:43 PM, David Miller wrote:
> From: Masayuki Ohtak <masa-korg@dsn.okisemi.com>
> Date: Fri, 15 Oct 2010 22:00:28 +0900
>
>> CAN driver of Topcliff PCH
>>
>> Topcliff PCH is the platform controller hub that is going to be used in
>> Intel's upcoming general embedded platform. All IO peripherals in
>> Topcliff PCH are actually devices sitting on AMBA bus.
>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>
>> Signed-off-by: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
>
> Applied, thanks.
IMHO this driver needs some improvements. There are some open points
from Wolfgangs and my review. On the other side, it's a new driver and
there's some time left before it hits mainline.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2010-10-24 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 13:00 [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35 Masayuki Ohtak
2010-10-24 21:43 ` David Miller
2010-10-24 21:55 ` David Miller
2010-10-24 22:05 ` Marc Kleine-Budde [this message]
2010-10-24 22:09 ` David Miller
2010-10-24 22:15 ` Marc Kleine-Budde
2010-10-25 7:06 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC4ADA5.8@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox