From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755993Ab0JYOnK (ORCPT ); Mon, 25 Oct 2010 10:43:10 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:17773 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680Ab0JYOnI (ORCPT ); Mon, 25 Oct 2010 10:43:08 -0400 Message-ID: <4CC59765.5080908@oracle.com> Date: Mon, 25 Oct 2010 07:42:45 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Michal Marek CC: Namhyung Kim , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kbuild: check return value of asprintf() References: <1287757930-2766-1-git-send-email-namhyung@gmail.com> <4CC54E4D.7040401@suse.cz> In-Reply-To: <4CC54E4D.7040401@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/10 02:30, Michal Marek wrote: > (adding Randy to CC) Thanks, Michal. Acked-by: Randy Dunlap > On 22.10.2010 16:32, Namhyung Kim wrote: >> Check return value of asprintf() in docsect() and exit if error >> occurs. This removes following warning: >> >> HOSTCC scripts/basic/docproc >> scripts/basic/docproc.c: In function ‘docsect’: >> scripts/basic/docproc.c:336: warning: ignoring return value of ‘asprintf’, >> declared with attribute warn_unused_result >> >> Signed-off-by: Namhyung Kim >> --- >> The patch is on top of v2.6.36, thanks. >> >> scripts/basic/docproc.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c >> index fc3b18d..98dec87 100644 >> --- a/scripts/basic/docproc.c >> +++ b/scripts/basic/docproc.c >> @@ -333,7 +333,10 @@ static void docsect(char *filename, char *line) >> if (*s == '\n') >> *s = '\0'; >> >> - asprintf(&s, "DOC: %s", line); >> + if (asprintf(&s, "DOC: %s", line) < 0) { >> + perror("asprintf"); >> + exit(1); >> + } >> consume_symbol(s); >> free(s); >> > -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***