From: Tejun Heo <tj@kernel.org>
To: Alexey Zaytsev <alexey.zaytsev@gmail.com>, bphilips@suse.de
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
Kumar Gala <galak@kernel.crashing.org>
Subject: Re: Adding more stuff to devres.
Date: Tue, 26 Oct 2010 11:30:34 +0200 [thread overview]
Message-ID: <4CC69FBA.1010001@kernel.org> (raw)
In-Reply-To: <AANLkTikx2TYO_NN91FzOq_0wxOJ_ggQVsxgOHNOpRom5@mail.gmail.com>
Adding Brandon, Hi.
On 10/25/2010 05:52 PM, Alexey Zaytsev wrote:
> Would it be a good idea to get things other than resources managed by
> the devres?
>
> In my probe() method, I still have to handle alloc_netdev() and
> mdiobus_alloc(). Adding corresponding devm_ functions should be
> trivial. So, should I prepare the patches, or is there something wrong
> with the approach?
Hmmm... Unless alloc_netdev() and mdiobus_alloc() are allocating
something special, I think it probably would be better to make them
use devres. Please take a look at how ata_host_alloc() and
ata_host_start() are doing it.
IIRC, Brandon spent some time thinking about how use devres on network
drivers. Brandon, any ideas?
Thanks.
--
tejun
prev parent reply other threads:[~2010-10-26 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 15:52 Adding more stuff to devres Alexey Zaytsev
2010-10-26 9:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC69FBA.1010001@kernel.org \
--to=tj@kernel.org \
--cc=alexey.zaytsev@gmail.com \
--cc=bphilips@suse.de \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox