* Adding more stuff to devres.
@ 2010-10-25 15:52 Alexey Zaytsev
2010-10-26 9:30 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Zaytsev @ 2010-10-25 15:52 UTC (permalink / raw)
To: Kernel development list; +Cc: Tejun Heo, Kumar Gala
Hi.
Would it be a good idea to get things other than resources managed by
the devres?
In my probe() method, I still have to handle alloc_netdev() and
mdiobus_alloc(). Adding corresponding devm_ functions should be
trivial. So, should I prepare the patches, or is there something wrong
with the approach?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Adding more stuff to devres.
2010-10-25 15:52 Adding more stuff to devres Alexey Zaytsev
@ 2010-10-26 9:30 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2010-10-26 9:30 UTC (permalink / raw)
To: Alexey Zaytsev, bphilips; +Cc: Kernel development list, Kumar Gala
Adding Brandon, Hi.
On 10/25/2010 05:52 PM, Alexey Zaytsev wrote:
> Would it be a good idea to get things other than resources managed by
> the devres?
>
> In my probe() method, I still have to handle alloc_netdev() and
> mdiobus_alloc(). Adding corresponding devm_ functions should be
> trivial. So, should I prepare the patches, or is there something wrong
> with the approach?
Hmmm... Unless alloc_netdev() and mdiobus_alloc() are allocating
something special, I think it probably would be better to make them
use devres. Please take a look at how ata_host_alloc() and
ata_host_start() are doing it.
IIRC, Brandon spent some time thinking about how use devres on network
drivers. Brandon, any ideas?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-26 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-25 15:52 Adding more stuff to devres Alexey Zaytsev
2010-10-26 9:30 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox