From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933525Ab0JZTNG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Oct 2010 15:13:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46451 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755976Ab0JZTNF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Oct 2010 15:13:05 -0400
Message-ID: <4CC7283D.3010205@redhat.com>
Date: Tue, 26 Oct 2010 17:13:01 -0200
From: Mauro Carvalho Chehab <mchehab@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Lightning/1.0b2 Thunderbird/3.1.3
MIME-Version: 1.0
To: Randy Dunlap <rdunlap@xenotime.net>
CC: lkml <linux-kernel@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: docbook: fix fatal error in linux/input.h
References: <20101026114555.4b79977d.rdunlap@xenotime.net>
In-Reply-To: <20101026114555.4b79977d.rdunlap@xenotime.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em 26-10-2010 16:45, Randy Dunlap escreveu:
> Hi,
> 
> Recent commit 8613e4c2872a87cc309a42de2c7091744dc54d0e:
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Thu Sep 9 21:54:22 2010 -0700
>     Input: add support for large scancodes
> 
> causes a fatal error in docbook generation:
> 
> linux-2.6.36-git8/DOC1/Documentation/DocBook/device-drivers.xml:40690: parser error : StartTag: invalid element name
> #define INPUT_KEYMAP_BY_INDEX	(1 << 0)
>                              	    ^
> 
> I think that this message comes from xsltproc, but I'm not positive about that.
> I also don't know of a really good fix for it.  However, I did find 2 ways to
> work around the error:
> 
> a/ move the #define value to after the end of the struct input_keymap_entry, like:
> 
> /* flags bits: */
> #define INPUT_KEYMAP_BY_INDEX	(1 << 0)
> 
> or
> b/ don't use the "<< 0" (can leave the #define where it is in this case):
> #define INPUT_KEYMAP_BY_INDEX	(1)
> 
> I have tested both of these patches and they work OK.
> Are you OK with either of them?  or want to choose one?


Hmm... probably, the first one is not correct.

I suspect that the right way is to use something like:

	#define INPUT_KEYMAP_BY_INDEX	(1 &lt;&lt; 0)

Could you please test if this would fix the issue?

Thanks,
Mauro