From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802Ab0J0Jkz (ORCPT ); Wed, 27 Oct 2010 05:40:55 -0400 Received: from exprod5og104.obsmtp.com ([64.18.0.178]:42449 "EHLO exprod5og104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651Ab0J0Jkx (ORCPT ); Wed, 27 Oct 2010 05:40:53 -0400 Message-ID: <4CC7F352.5030008@ge.com> Date: Wed, 27 Oct 2010 10:39:30 +0100 From: Martyn Welch Organization: GE Intelligent Platforms User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.14) Gecko/20101006 Thunderbird/3.0.9 MIME-Version: 1.0 To: "Emilio G. Cota" CC: Greg KH , LKML , devel@driverdev.osuosl.org, Juan David Gonzalez Cobas , Bill Pemberton Subject: Re: [PATCH 03/30] staging/vme_user: remove unreachable line References: <1288055476-19438-1-git-send-email-cota@braap.org> <1288055476-19438-4-git-send-email-cota@braap.org> In-Reply-To: <1288055476-19438-4-git-send-email-cota@braap.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Oct 2010 09:40:48.0791 (UTC) FILETIME=[0970C270:01CB75BB] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/10 02:10, Emilio G. Cota wrote: > From: Emilio G. Cota > > Signed-off-by: Emilio G. Cota This line was provided to aid future development. It is the command needed to undo the last function call to the function. On balance I guess this is as likely to end up causing as many problems as it aims to solve, so I guess it's worth getting rid of it: Acked-by: Martyn Welch > --- > drivers/staging/vme/devices/vme_user.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c > index a6f6116..bdc4e1e 100644 > --- a/drivers/staging/vme/devices/vme_user.c > +++ b/drivers/staging/vme/devices/vme_user.c > @@ -654,7 +654,6 @@ static int __init vme_user_init(void) > > return retval; > > - vme_unregister_driver(&vme_user_driver); > err_reg: > kfree(ids); > err_id: -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@ge.com | M2 3AB VAT:GB 927559189