public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: fyi: gcc33-hammer crashes when compiling kvm emulate.c
Date: Wed, 27 Oct 2010 12:50:05 +0200	[thread overview]
Message-ID: <4CC803DD.2010508@redhat.com> (raw)
In-Reply-To: <4CC73C07.3030704@zytor.com>

  On 10/26/2010 10:37 PM, H. Peter Anvin wrote:
> On 10/26/2010 01:27 PM, Andi Kleen wrote:
> >>  That is an issue too, as 3.x does a lot fewer optimizations than 4.x.
> >
> >  Well to be fair the default -Os build disables most of the fancy stuff
> >  (and the resulting code is often terrible)
> >
> >  I guess it doesn't matter too much, at least not with the
> >  CONFIG_CC_OPTIMIZE_SIZE default.
> >
>
> Yes, it would be nice to have a setting which is "optimize but don't
> bloat excessively."
>

Would be good to have __fastpath and __slowpath function attributes.

__fastpath would always be optimized for speed, __slowpath always for 
size, and everything else would use the default (determined by 
CONFIG_CC_OPTIMIZE_FOR_SIZE).

Looks like gcc has support for this, with __attribute__((hot)), 
__attribute__((cold)), and __attribute__((optimize)).

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2010-10-27 10:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 12:38 fyi: gcc33-hammer crashes when compiling kvm emulate.c Andi Kleen
2010-10-26 16:34 ` H. Peter Anvin
2010-10-26 16:37   ` Andi Kleen
2010-10-26 16:46     ` H. Peter Anvin
2010-10-26 17:01       ` Andi Kleen
2010-10-26 18:19         ` H. Peter Anvin
2010-10-26 20:27           ` Andi Kleen
2010-10-26 20:37             ` H. Peter Anvin
2010-10-27 10:50               ` Avi Kivity [this message]
2010-10-27 17:00                 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC803DD.2010508@redhat.com \
    --to=avi@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox