From: Martyn Welch <martyn.welch@ge.com>
To: "Emilio G. Cota" <cota@braap.org>
Cc: Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org,
Juan David Gonzalez Cobas <david.cobas@gmail.com>,
Bill Pemberton <wfp5p@virginia.edu>
Subject: Re: [PATCH 11/30] staging/vme/tsi148: declare static functions as such
Date: Wed, 27 Oct 2010 12:23:57 +0100 [thread overview]
Message-ID: <4CC80BCD.8010301@ge.com> (raw)
In-Reply-To: <1288055476-19438-12-git-send-email-cota@braap.org>
On 26/10/10 02:10, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@braap.org>
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
Acked-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_tsi148.c | 38 +++++++++++++++---------------
> 1 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index c08927e..3ef5f48 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -392,7 +392,7 @@ static void tsi148_irq_exit(struct vme_bridge *tsi148_bridge, struct pci_dev *pd
> /*
> * Check to see if an IACk has been received, return true (1) or false (0).
> */
> -int tsi148_iack_received(struct tsi148_driver *bridge)
> +static int tsi148_iack_received(struct tsi148_driver *bridge)
> {
> u32 tmp;
>
> @@ -407,7 +407,7 @@ int tsi148_iack_received(struct tsi148_driver *bridge)
> /*
> * Configure VME interrupt
> */
> -void tsi148_irq_set(struct vme_bridge *tsi148_bridge, int level,
> +static void tsi148_irq_set(struct vme_bridge *tsi148_bridge, int level,
> int state, int sync)
> {
> struct pci_dev *pdev;
> @@ -447,7 +447,7 @@ void tsi148_irq_set(struct vme_bridge *tsi148_bridge, int level,
> * Generate a VME bus interrupt at the requested level & vector. Wait for
> * interrupt to be acked.
> */
> -int tsi148_irq_generate(struct vme_bridge *tsi148_bridge, int level, int statid)
> +static int tsi148_irq_generate(struct vme_bridge *tsi148_bridge, int level, int statid)
> {
> u32 tmp;
> struct tsi148_driver *bridge;
> @@ -547,7 +547,7 @@ static void tsi148_clear_errors(struct vme_bridge *tsi148_bridge,
> /*
> * Initialize a slave window with the requested attributes.
> */
> -int tsi148_slave_set(struct vme_slave_resource *image, int enabled,
> +static int tsi148_slave_set(struct vme_slave_resource *image, int enabled,
> unsigned long long vme_base, unsigned long long size,
> dma_addr_t pci_base, vme_address_t aspace, vme_cycle_t cycle)
> {
> @@ -697,7 +697,7 @@ int tsi148_slave_set(struct vme_slave_resource *image, int enabled,
> /*
> * Get slave window configuration.
> */
> -int tsi148_slave_get(struct vme_slave_resource *image, int *enabled,
> +static int tsi148_slave_get(struct vme_slave_resource *image, int *enabled,
> unsigned long long *vme_base, unsigned long long *size,
> dma_addr_t *pci_base, vme_address_t *aspace, vme_cycle_t *cycle)
> {
> @@ -893,7 +893,7 @@ static void tsi148_free_resource(struct vme_master_resource *image)
> /*
> * Set the attributes of an outbound window.
> */
> -int tsi148_master_set(struct vme_master_resource *image, int enabled,
> +static int tsi148_master_set(struct vme_master_resource *image, int enabled,
> unsigned long long vme_base, unsigned long long size,
> vme_address_t aspace, vme_cycle_t cycle, vme_width_t dwidth)
> {
> @@ -1129,7 +1129,7 @@ err_window:
> *
> * XXX Not parsing prefetch information.
> */
> -int __tsi148_master_get(struct vme_master_resource *image, int *enabled,
> +static int __tsi148_master_get(struct vme_master_resource *image, int *enabled,
> unsigned long long *vme_base, unsigned long long *size,
> vme_address_t *aspace, vme_cycle_t *cycle, vme_width_t *dwidth)
> {
> @@ -1239,7 +1239,7 @@ int __tsi148_master_get(struct vme_master_resource *image, int *enabled,
> }
>
>
> -int tsi148_master_get(struct vme_master_resource *image, int *enabled,
> +static int tsi148_master_get(struct vme_master_resource *image, int *enabled,
> unsigned long long *vme_base, unsigned long long *size,
> vme_address_t *aspace, vme_cycle_t *cycle, vme_width_t *dwidth)
> {
> @@ -1255,7 +1255,7 @@ int tsi148_master_get(struct vme_master_resource *image, int *enabled,
> return retval;
> }
>
> -ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf,
> +static ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf,
> size_t count, loff_t offset)
> {
> int retval, enabled;
> @@ -1297,7 +1297,7 @@ skip_chk:
> }
>
>
> -ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf,
> +static ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf,
> size_t count, loff_t offset)
> {
> int retval = 0, enabled;
> @@ -1364,7 +1364,7 @@ skip_chk:
> *
> * Requires a previously configured master window, returns final value.
> */
> -unsigned int tsi148_master_rmw(struct vme_master_resource *image,
> +static unsigned int tsi148_master_rmw(struct vme_master_resource *image,
> unsigned int mask, unsigned int compare, unsigned int swap,
> loff_t offset)
> {
> @@ -1611,7 +1611,7 @@ static int tsi148_dma_set_vme_dest_attributes(struct device *dev, u32 *attr,
> /*
> * Add a link list descriptor to the list
> */
> -int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> +static int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> struct vme_dma_attr *dest, size_t count)
> {
> struct tsi148_dma_entry *entry, *prev;
> @@ -1784,7 +1784,7 @@ static int tsi148_dma_busy(struct vme_bridge *tsi148_bridge, int channel)
> *
> * XXX Need to provide control register configuration.
> */
> -int tsi148_dma_list_exec(struct vme_dma_list *list)
> +static int tsi148_dma_list_exec(struct vme_dma_list *list)
> {
> struct vme_dma_resource *ctrlr;
> int channel, retval = 0;
> @@ -1864,7 +1864,7 @@ int tsi148_dma_list_exec(struct vme_dma_list *list)
> *
> * We have a separate function, don't assume that the chain can't be reused.
> */
> -int tsi148_dma_list_empty(struct vme_dma_list *list)
> +static int tsi148_dma_list_empty(struct vme_dma_list *list)
> {
> struct list_head *pos, *temp;
> struct tsi148_dma_entry *entry;
> @@ -1886,7 +1886,7 @@ int tsi148_dma_list_empty(struct vme_dma_list *list)
> * This does not enable the LM monitor - that should be done when the first
> * callback is attached and disabled when the last callback is removed.
> */
> -int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,
> +static int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,
> vme_address_t aspace, vme_cycle_t cycle)
> {
> u32 lm_base_high, lm_base_low, lm_ctl = 0;
> @@ -1953,7 +1953,7 @@ int tsi148_lm_set(struct vme_lm_resource *lm, unsigned long long lm_base,
> /* Get configuration of the callback monitor and return whether it is enabled
> * or disabled.
> */
> -int tsi148_lm_get(struct vme_lm_resource *lm, unsigned long long *lm_base,
> +static int tsi148_lm_get(struct vme_lm_resource *lm, unsigned long long *lm_base,
> vme_address_t *aspace, vme_cycle_t *cycle)
> {
> u32 lm_base_high, lm_base_low, lm_ctl, enabled = 0;
> @@ -2004,7 +2004,7 @@ int tsi148_lm_get(struct vme_lm_resource *lm, unsigned long long *lm_base,
> *
> * Callback will be passed the monitor triggered.
> */
> -int tsi148_lm_attach(struct vme_lm_resource *lm, int monitor,
> +static int tsi148_lm_attach(struct vme_lm_resource *lm, int monitor,
> void (*callback)(int))
> {
> u32 lm_ctl, tmp;
> @@ -2059,7 +2059,7 @@ int tsi148_lm_attach(struct vme_lm_resource *lm, int monitor,
> /*
> * Detach a callback function forn a specific location monitor.
> */
> -int tsi148_lm_detach(struct vme_lm_resource *lm, int monitor)
> +static int tsi148_lm_detach(struct vme_lm_resource *lm, int monitor)
> {
> u32 lm_en, tmp;
> struct tsi148_driver *bridge;
> @@ -2099,7 +2099,7 @@ int tsi148_lm_detach(struct vme_lm_resource *lm, int monitor)
> /*
> * Determine Geographical Addressing
> */
> -int tsi148_slot_get(struct vme_bridge *tsi148_bridge)
> +static int tsi148_slot_get(struct vme_bridge *tsi148_bridge)
> {
> u32 slot = 0;
> struct tsi148_driver *bridge;
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square,
Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
next prev parent reply other threads:[~2010-10-27 11:25 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 1:10 [re-send][-next] staging/vme: various fixes + new driver model for VME Emilio G. Cota
2010-10-26 1:10 ` [PATCH 01/30] staging/vme: style: convert '&(foo)' to '&foo' Emilio G. Cota
2010-10-27 9:17 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 02/30] staging/vme_user: return the appropriate error code when module_init fails Emilio G. Cota
2010-10-27 9:25 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 03/30] staging/vme_user: remove unreachable line Emilio G. Cota
2010-10-27 9:39 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 04/30] staging/vme: allow non-dynamic allocation of bus numbers Emilio G. Cota
2010-10-27 9:41 ` Martyn Welch
2010-10-27 15:13 ` Emilio G. Cota
2010-11-04 3:40 ` Emilio G. Cota
2010-11-05 16:29 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 05/30] staging/vme: fix bogus clearing of the bus number in vme_free_bus_num Emilio G. Cota
2010-10-27 9:49 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 06/30] staging/vme/tsi148: use list_for_each_safe when deleting resources in .remove Emilio G. Cota
2010-10-27 9:51 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 07/30] staging/vme/tsi148: remove double freeing of the IRQ " Emilio G. Cota
2010-10-27 10:01 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 08/30] staging/vme/tsi148: fix warning in free_irq Emilio G. Cota
2010-10-27 10:23 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 09/30] staging/vme: fill in struct device's .release, even if it's a NOOP Emilio G. Cota
2010-10-27 10:54 ` Martyn Welch
2010-10-27 14:46 ` Emilio G. Cota
2010-10-27 15:03 ` Martyn Welch
2010-10-27 15:15 ` Emilio G. Cota
2010-10-28 1:17 ` Greg KH
2010-10-28 6:07 ` Emilio G. Cota
2010-10-28 17:56 ` Greg KH
2010-11-12 11:13 ` [PATCH 00/17] Series short description Martyn Welch
2010-11-12 11:14 ` [PATCH 01/17] staging/vme: style: convert '&(foo)' to '&foo' Martyn Welch
2010-11-12 11:14 ` [PATCH 02/17] staging/vme_user: return the appropriate error code when module_init fails Martyn Welch
2010-11-12 11:14 ` [PATCH 03/17] staging/vme_user: remove unreachable line Martyn Welch
2010-11-12 11:14 ` [PATCH 04/17] staging/vme: fix bogus clearing of the bus number in vme_free_bus_num Martyn Welch
2010-11-12 11:14 ` [PATCH 05/17] staging/vme/tsi148: use list_for_each_safe when deleting resources in .remove Martyn Welch
2010-11-12 11:14 ` [PATCH 06/17] staging/vme/tsi148: remove double freeing of the IRQ " Martyn Welch
2010-11-12 11:14 ` [PATCH 07/17] staging/vme/tsi148: fix warning in free_irq Martyn Welch
2010-11-12 11:14 ` [PATCH 08/17] staging/vme/tsi148: remove unreachable line Martyn Welch
2010-11-12 11:15 ` [PATCH 09/17] staging/vme/tsi148: declare static functions as such Martyn Welch
2010-11-12 11:15 ` [PATCH 10/17] staging/vme/ca91cx42: " Martyn Welch
2010-11-12 11:15 ` [PATCH 11/17] staging/vme_user: declare private variables as static Martyn Welch
2010-11-12 11:15 ` [PATCH 12/17] staging/vme_user: use an unsigned int for counting the number of kparams Martyn Welch
2010-11-12 11:15 ` [PATCH 13/17] staging/vme_user: remove __iomem marking from kern_buf and derivates Martyn Welch
2010-11-12 11:15 ` [PATCH 14/17] staging/vme_user: mark user-space buffers with __user Martyn Welch
2010-11-12 11:15 ` [PATCH 15/17] staging/vme: mark struct vme_master_resource's base address pointer as __iomem Martyn Welch
2010-11-12 11:15 ` [PATCH 16/17] staging/vme/tsi148: mark the registers' " Martyn Welch
2010-11-12 11:15 ` [PATCH 17/17] staging/vme/ca91cx42: " Martyn Welch
2010-11-12 11:23 ` [PATCH 00/17] Series short description Martyn Welch
2010-11-12 15:11 ` Emilio G. Cota
2010-11-12 15:52 ` Martyn Welch
2010-11-16 19:40 ` Greg KH
2010-10-26 1:10 ` [PATCH 10/30] staging/vme/tsi148: remove unreachable line Emilio G. Cota
2010-10-27 11:06 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 11/30] staging/vme/tsi148: declare static functions as such Emilio G. Cota
2010-10-27 11:23 ` Martyn Welch [this message]
2010-10-26 1:10 ` [PATCH 12/30] staging/vme/ca91cx42: " Emilio G. Cota
2010-10-27 11:24 ` Martyn Welch
2010-10-26 1:10 ` [PATCH 13/30] staging/vme_user: declare private variables as static Emilio G. Cota
2010-10-27 11:29 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 14/30] staging/vme_user: use an unsigned int for counting the number of kparams Emilio G. Cota
2010-10-27 11:29 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 15/30] staging/vme_user: remove __iomem marking from kern_buf and derivates Emilio G. Cota
2010-10-27 12:20 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 16/30] staging/vme_user: mark user-space buffers with __user Emilio G. Cota
2010-10-27 12:20 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 17/30] staging/vme: mark struct vme_master_resource's base address pointer as __iomem Emilio G. Cota
2010-10-27 12:20 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 18/30] staging/vme/tsi148: mark the registers' " Emilio G. Cota
2010-10-27 12:20 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 19/30] staging/vme/ca91cx42: " Emilio G. Cota
2010-10-27 12:20 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 20/30] staging/vme: trivial: rename vme_bus_num_mtx to vme_buses_lock Emilio G. Cota
2010-10-26 1:11 ` [PATCH 21/30] staging/vme: keep a list of registered buses (bridges) Emilio G. Cota
2010-10-26 1:11 ` [PATCH 22/30] staging/vme/vme_user: use __dev{init,exit} for .probe and .remove Emilio G. Cota
2010-12-03 13:44 ` [PATCH] staging/vme/vme_user: use __dev{init, exit} " Martyn Welch
2010-10-26 1:11 ` [PATCH 23/30] staging/vme_user: fix usage of the slave resources after they've been freed Emilio G. Cota
2010-12-03 9:05 ` [PATCH] " Martyn Welch
2010-10-26 1:11 ` [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave_set Emilio G. Cota
2010-10-27 12:24 ` Martyn Welch
2010-10-27 14:59 ` Emilio G. Cota
2010-10-26 1:11 ` [PATCH 25/30] staging/vme_user: add missing calls to vme_master_free calls in .remove Emilio G. Cota
2010-12-03 14:20 ` [PATCH] " Martyn Welch
2010-12-03 14:44 ` Greg KH
2010-12-03 15:29 ` Martyn Welch
2010-10-26 1:11 ` [PATCH 26/30] staging/vme: move all contents of vme_bridge.h to vme.h Emilio G. Cota
2010-10-26 1:11 ` [PATCH 27/30] staging/vme: rework the bus model Emilio G. Cota
2010-11-04 4:16 ` Emilio G. Cota
2010-10-26 1:11 ` [PATCH 28/30] staging/vme: convert vme_* users to vme_*_ng Emilio G. Cota
2010-10-26 1:11 ` [PATCH 29/30] staging/vme: remove unused vme_* functions and related code Emilio G. Cota
2010-10-26 1:11 ` [PATCH 30/30] staging/vme: remove _ng suffixes Emilio G. Cota
2010-11-09 23:12 ` [re-send][-next] staging/vme: various fixes + new driver model for VME Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-10-22 6:36 [-next] " Emilio G. Cota
2010-10-22 6:36 ` [PATCH 11/30] staging/vme/tsi148: declare static functions as such Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC80BCD.8010301@ge.com \
--to=martyn.welch@ge.com \
--cc=cota@braap.org \
--cc=david.cobas@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox