From: Jason Wessel <jason.wessel@windriver.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net
Subject: Re: [PATCH] kdb: avoid on-stack cpumask, old-style accessors
Date: Wed, 27 Oct 2010 06:44:32 -0500 [thread overview]
Message-ID: <4CC810A0.80609@windriver.com> (raw)
In-Reply-To: <201010272030.34310.rusty@rustcorp.com.au>
On 10/27/2010 05:00 AM, Rusty Russell wrote:
> That's quite a big stack already; I assume moving it to a static bitmap
> is OK for this usage (a cpumask_var_t might require kmalloc, not sure
> that's a good idea here).
>
>
Hi Rusty,
This patch seems fine to me, and I'll gladly put it in the merge queue.
The kdb shell has a 2 phase initialization, in order to support early
debugging (before the kernel allocators are ready as well as before
console init). In the later initialization phase, kmalloc() is
available. We could return an error up until the structure is allocated
by the kdb late init phase. It is also possible to avoid allocating the
structure at all if kdb is not configured and free it if you deactivate kdb.
If you are interested or think we should go down that path, let me know.
Thanks,
Jason.
next prev parent reply other threads:[~2010-10-27 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 10:00 [PATCH] kdb: avoid on-stack cpumask, old-style accessors Rusty Russell
2010-10-27 11:44 ` Jason Wessel [this message]
2010-10-29 9:48 ` Rusty Russell
2010-10-29 13:11 ` Jason Wessel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC810A0.80609@windriver.com \
--to=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox