From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760982Ab0J0Ly7 (ORCPT ); Wed, 27 Oct 2010 07:54:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48304 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757702Ab0J0Lyy (ORCPT ); Wed, 27 Oct 2010 07:54:54 -0400 Message-ID: <4CC812DD.9050608@redhat.com> Date: Wed, 27 Oct 2010 13:54:05 +0200 From: Tomas Henzl User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 MIME-Version: 1.0 To: "Yang, Bo" CC: James Bottomley , bo yang , "linux-scsi@vger.kernel.org" , "akpm@osdl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/5] scsi: megaraid_sas - Version and documentation update References: <4B6A08C587958942AA3002690DD4F8C30100FF9FBB@cosmail02.lsi.com> <1288109543.8283.139.camel@mulgrave.site> <4B6A08C587958942AA3002690DD4F8C3010119E798@cosmail02.lsi.com> In-Reply-To: <4B6A08C587958942AA3002690DD4F8C3010119E798@cosmail02.lsi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2010 07:15 PM, Yang, Bo wrote: > James, > > Thanks for correcting that. Did you also applied 2/5, 3/5 and 4/5 patches? > > By the way, I always use checkpatch.pl to check the patch before I attach the patch to the e-mail. Also I just went to the 5/5 patch to verify the patch: the steps: > > 1. go to http://marc.info/?l=linux-scsi&m=128688974201201&w=2 > Looking carefully at the above page (select the text) you can see the trailing whitespaces directly on that page. > 2. click: ["megasas-version.patch" (application/octet-stream)] to download this patch. > 3. Used the checkpatch.pl to check (I used the cmd: "checkpatch.pl --no-tree megasas-version.patch") > > It looks OK for me (no errors). It is maybe the checkpatch.pl I used does not get updated or some steps are not correct. I will find out the updated one to try and find out the reasons. > Use the checkpatch.pl from the scripts directory > > Thanks, > > Bo Yang > > > -----Original Message----- > From: James Bottomley [mailto:James.Bottomley@suse.de] > Sent: Tuesday, October 26, 2010 12:12 PM > To: Yang, Bo > Cc: bo yang; linux-scsi@vger.kernel.org; akpm@osdl.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 5/5] scsi: megaraid_sas - Version and documentation update > > On Tue, 2010-10-12 at 07:21 -0600, Yang, Bo wrote: > >> Re-Submit: >> >> Update the version and documentation. >> > This has an impressive set of checkpatch failures: > > ERROR: trailing whitespace > #26: FILE: Documentation/scsi/ChangeLog.megaraid_sas:13: > +^ITo add the OCR support, driver need to do: $ > > ERROR: trailing whitespace > #30: FILE: Documentation/scsi/ChangeLog.megaraid_sas:17: > +^I^I$ > > ERROR: trailing whitespace > #35: FILE: Documentation/scsi/ChangeLog.megaraid_sas:22: > +^I^I$ > > ERROR: trailing whitespace > #39: FILE: Documentation/scsi/ChangeLog.megaraid_sas:26: > +^I^I$ > > ERROR: trailing whitespace > #43: FILE: Documentation/scsi/ChangeLog.megaraid_sas:30: > +^I^I$ > > ERROR: trailing whitespace > #46: FILE: Documentation/scsi/ChangeLog.megaraid_sas:33: > +^I^I $ > > ERROR: trailing whitespace > #48: FILE: Documentation/scsi/ChangeLog.megaraid_sas:35: > +^I^IOCR to see if driver can bring back the FW. $ > > ERROR: trailing whitespace > #54: FILE: Documentation/scsi/ChangeLog.megaraid_sas:41: > +3.^IIn driver's timeout routine, driver will do three time reset if fw > is in $ > > total: 8 errors, 0 warnings, 70 lines checked > > I've fixed it up this time, but could you run it through checkpatch.pl > next time? > > Thanks, > > James > > > N�����r��y���b�X��ǧv�^�)޺{.n�+����{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�m��������zZ+��ݢj"��!tml=