From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709Ab0J0RLK (ORCPT ); Wed, 27 Oct 2010 13:11:10 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:59743 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463Ab0J0RLI (ORCPT ); Wed, 27 Oct 2010 13:11:08 -0400 X-Greylist: delayed 1779 seconds by postgrey-1.27 at vger.kernel.org; Wed, 27 Oct 2010 13:11:07 EDT Message-ID: <4CC85633.6030707@iki.fi> Date: Wed, 27 Oct 2010 19:41:23 +0300 From: Antti Palosaari User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Thunderbird/3.1.4 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Jiri Slaby , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mm-commits@vger.kernel.org, Greg KH , USB list Subject: Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded] References: <201010202233.o9KMXNoL008303@imap1.linux-foundation.org> <4CC07DB4.20205@gmail.com> <4CC1577F.9060207@gmail.com> <4CC19804.1080109@redhat.com> <4CC19A6E.8010909@gmail.com> <4CC84F60.7000409@redhat.com> In-Reply-To: <4CC84F60.7000409@redhat.com> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 82.128.185.158 X-SA-Exim-Mail-From: crope@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2010 07:12 PM, Mauro Carvalho Chehab wrote: > int tda18271_write_regs(struct dvb_frontend *fe, int idx, int len) > { > ... > switch (priv->small_i2c) { > case TDA18271_03_BYTE_CHUNK_INIT: > max = 3; > break; > case TDA18271_08_BYTE_CHUNK_INIT: > max = 8; > break; > case TDA18271_16_BYTE_CHUNK_INIT: > max = 16; > break; > case TDA18271_39_BYTE_CHUNK_INIT: > default: > max = 39; > } > > > with small_i2c = 1, the driver will not restrict the maximum length size. > > It's weird that the patch didn't fix it. Are you sure that reverting this > patch is enough to make the driver work? > > Please test this one. > > It will properly log the size of the message the driver tried to use, and will > reduce the max number of bytes per I2C transfer to 8. All in all, this small_i2c was added (Michael Krufky and I) when this tuner was taken in use with af9015 and it was 16 bytes initially. I think those other chunks are added later. AF9015 I2C adapter can write 21 bytes at once. Correct solution is to add option which splits writes as wanted (like option .i2c_wr_max) to the TDA18271. I have no HW to test. Antti -- http://palosaari.fi/