public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] fix for loop warning
@ 2010-10-27  4:18 Jens Axboe
  2010-10-28  1:47 ` Linus Torvalds
  2010-10-28 11:38 ` Christoph Hellwig
  0 siblings, 2 replies; 4+ messages in thread
From: Jens Axboe @ 2010-10-27  4:18 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel@vger.kernel.org

Hi Linus,

One-liner fix for a warning regression introduced with the
loop changes pulled for 2.6.37-rc1

Please pull.

The following changes since commit 9db59aff3fb32b05a7e2464dd543de03b2b3cebc:

  loop: Properly clear sysfs in autoclear mode (2010-10-26 22:13:27 -0600)

are available in the git repository at:

  git://git.kernel.dk/linux-2.6-block.git for-linus

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1e5284e..450c958 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
 	if (bdev)
 		invalidate_bdev(bdev);
 	set_capacity(lo->lo_disk, 0);
-	loop_sysfs_exit(lo);
 	if (bdev) {
 		bd_set_size(bdev, 0);
+		loop_sysfs_exit(lo);
 		/* let user-space know about this change */
 		kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
 	}

-- 
Jens Axboe


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] fix for loop warning
  2010-10-27  4:18 [GIT PULL] fix for loop warning Jens Axboe
@ 2010-10-28  1:47 ` Linus Torvalds
  2010-10-28 13:32   ` Jens Axboe
  2010-10-28 11:38 ` Christoph Hellwig
  1 sibling, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2010-10-28  1:47 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel@vger.kernel.org

On Tue, Oct 26, 2010 at 9:18 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
>
>  git://git.kernel.dk/linux-2.6-block.git for-linus

"Already up-to-date."

Forgot to push?

                 Linus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] fix for loop warning
  2010-10-27  4:18 [GIT PULL] fix for loop warning Jens Axboe
  2010-10-28  1:47 ` Linus Torvalds
@ 2010-10-28 11:38 ` Christoph Hellwig
  1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2010-10-28 11:38 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Linus Torvalds, linux-kernel@vger.kernel.org

Linus, any reason this hasn't been merged yet?  It's pretty annoying
when e.g. running xfstests.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] fix for loop warning
  2010-10-28  1:47 ` Linus Torvalds
@ 2010-10-28 13:32   ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2010-10-28 13:32 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel@vger.kernel.org

On 2010-10-27 19:47, Linus Torvalds wrote:
> On Tue, Oct 26, 2010 at 9:18 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
>>
>>  git://git.kernel.dk/linux-2.6-block.git for-linus
> 
> "Already up-to-date."
> 
> Forgot to push?

Must have... The branch has now been updated with a few other pending
patches. All pretty trivial and straight forward changes.

Please pull (again :-).


  git://git.kernel.dk/linux-2.6-block.git for-linus

Andrew Morton (1):
      drivers/block/aoe/aoeblk.c: ratelimit a warning printk

Geert Uytterhoeven (1):
      drivers/block/z2ram.c: correct printing of sector_t

Mike Miller (1):
      cciss: remove overlapping PCI IDs

Milan Broz (1):
      loop: Properly clear sysfs in autoclear mode

Nicolas Kaiser (1):
      drivers/block/drbd/drbd_main.c: fix error path

Tejun Heo (1):
      aoe: don't use flush_scheduled_work()

Vasiliy Kulikov (1):
      block: cciss: fix information leak to userland

 drivers/block/aoe/aoeblk.c     |    4 +++-
 drivers/block/aoe/aoedev.c     |    4 +---
 drivers/block/cciss.c          |   37 +------------------------------------
 drivers/block/drbd/drbd_main.c |    2 +-
 drivers/block/loop.c           |    2 +-
 drivers/block/z2ram.c          |    6 ++++--
 6 files changed, 11 insertions(+), 44 deletions(-)


-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-10-28 13:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-27  4:18 [GIT PULL] fix for loop warning Jens Axboe
2010-10-28  1:47 ` Linus Torvalds
2010-10-28 13:32   ` Jens Axboe
2010-10-28 11:38 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox