From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760245Ab0J1VTQ (ORCPT ); Thu, 28 Oct 2010 17:19:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47580 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756714Ab0J1VTI (ORCPT ); Thu, 28 Oct 2010 17:19:08 -0400 Message-ID: <4CC9E8C7.60306@suse.cz> Date: Thu, 28 Oct 2010 23:19:03 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.11) Gecko/20100714 SUSE/3.0.6 Thunderbird/3.0.6 MIME-Version: 1.0 To: Sam Ravnborg Cc: Mike Frysinger , Hendrik Brueckner , Michael Holzheu , tabbott@ksplice.com, vda.linux@googlemail.com, hpa@linux.intel.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com Subject: Re: [PATCH] initramfs: Fix build break on symbol-prefixed archs References: <20100831083844.043619334@linux.vnet.ibm.com> <20101018103729.GA4122@linux.vnet.ibm.com> <20101019110801.GA4128@linux.vnet.ibm.com> <20101019213112.GA11432@merkur.ravnborg.org> <4CC8ABC7.5030003@suse.cz> <20101028203542.GA30879@merkur.ravnborg.org> In-Reply-To: <20101028203542.GA30879@merkur.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.10.2010 22:35, Sam Ravnborg wrote: > On Thu, Oct 28, 2010 at 12:46:31AM +0200, Michal Marek wrote: >> On 27.10.2010 20:23, Mike Frysinger wrote: >>> can we get this change dropped from linux-next until someone gets a >>> chance to fix it ? >> >> Sorry I missed this thread. So your last patch >> (http://lkml.org/lkml/2010/10/19/488) did fix the Blackfin build >> failure? Can you submit it with a proper Signed-off-by and changelog? > > Did you see the patch I posted in: http://lkml.org/lkml/2010/10/19/534 > > The one that fix up the cppflags usage. > > I think this will solve the issue with blackfin nicely - and > make use of cppflags more as expected. As Mike noted - your patch does not strip the double quotes. And Mike's patch is really minimal, it just adds the SYMBOL_PREFIX definition to _a_flags. I'll look at your patch after this merge window. Michal