public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Typo in tty_driver.h?
@ 2010-10-28 21:22 Timur Tabi
  2010-10-31  7:42 ` Jiri Slaby
  0 siblings, 1 reply; 3+ messages in thread
From: Timur Tabi @ 2010-10-28 21:22 UTC (permalink / raw)
  To: Linux Kernel Mailing List

I believe I found a typo in a comment in tty_driver.h

 * TTY_DRIVER_DYNAMIC_DEV --- if set, the individual tty devices need
 *	to be registered with a call to tty_register_driver() when the
 *	device is found in the system and unregistered with a call to
 *	tty_unregister_device() so the devices will be show up
 *	properly in sysfs.  If not set, driver->num entries will be
 *	created by the tty core in sysfs when tty_register_driver() is
 *	called.  This is to be used by drivers that have tty devices
 *	that can appear and disappear while the main tty driver is
 *	registered with the tty core.

On line 2, I think it should say "tty_register_device()" instead of
"tty_register_driver()".

-- 
Timur Tabi
Linux kernel developer at Freescale


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Typo in tty_driver.h?
  2010-10-28 21:22 Typo in tty_driver.h? Timur Tabi
@ 2010-10-31  7:42 ` Jiri Slaby
  2010-10-31 13:24   ` Tabi Timur-B04825
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2010-10-31  7:42 UTC (permalink / raw)
  To: Timur Tabi; +Cc: Linux Kernel Mailing List

On 10/28/2010 11:22 PM, Timur Tabi wrote:
> I believe I found a typo in a comment in tty_driver.h
> 
>  * TTY_DRIVER_DYNAMIC_DEV --- if set, the individual tty devices need
>  *	to be registered with a call to tty_register_driver() when the
>  *	device is found in the system and unregistered with a call to
>  *	tty_unregister_device() so the devices will be show up
>  *	properly in sysfs.  If not set, driver->num entries will be
>  *	created by the tty core in sysfs when tty_register_driver() is
>  *	called.  This is to be used by drivers that have tty devices
>  *	that can appear and disappear while the main tty driver is
>  *	registered with the tty core.
> 
> On line 2, I think it should say "tty_register_device()" instead of
> "tty_register_driver()".

Yes, you're correct. Care to bake a patch?

regards,
-- 
js
suse labs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Typo in tty_driver.h?
  2010-10-31  7:42 ` Jiri Slaby
@ 2010-10-31 13:24   ` Tabi Timur-B04825
  0 siblings, 0 replies; 3+ messages in thread
From: Tabi Timur-B04825 @ 2010-10-31 13:24 UTC (permalink / raw)
  To: Jiri Slaby; +Cc: Linux Kernel Mailing List

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 269 bytes --]

Jiri Slaby wrote:
> Yes, you're correct. Care to bake a patch?

Sure.

-- 
Timur Tabi
Linux kernel developer
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-31 13:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-28 21:22 Typo in tty_driver.h? Timur Tabi
2010-10-31  7:42 ` Jiri Slaby
2010-10-31 13:24   ` Tabi Timur-B04825

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox