From: "Eric Bénard" <eric@eukrea.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dinh.Nguyen@freescale.com, amit.kucheria@canonical.com,
linux@arm.linux.org.uk, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: imx: Fix GPIO_1_xx settings that are wrongly assumed
Date: Fri, 29 Oct 2010 00:27:35 +0200 [thread overview]
Message-ID: <4CC9F8D7.4070802@eukrea.com> (raw)
In-Reply-To: <20101028205945.GE31158@pengutronix.de>
Hi Uwe,
Le 28/10/2010 22:59, Uwe Kleine-König a écrit :
> Before b545d9ed1b92f169d0326afac091328be5e76620 the muxmode entries were
> correct. Back when I looked at the patch that resulted into b545d9ed1b9
> I wondered if the intended change was only
> s/NO_PAD_CTRL/MX51_GPIO_PAD_CTRL/ but didn't check the reference manual.
>
> Eric?
>
GPIO_PAD_CTRL was the original wanted change for that patch and while looking
at this I misread the iomux pages in the manual for gpio 2 to 9 which leads to
the mux error.
BTW, Arnaud Patard already provided a fix to this in it's efikamx patch serie.
Eric
prev parent reply other threads:[~2010-10-28 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:02 [PATCH] ARM: imx: Fix GPIO_1_xx settings that are wrongly assumed Dinh.Nguyen
2010-10-28 20:59 ` Uwe Kleine-König
2010-10-28 22:27 ` Eric Bénard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC9F8D7.4070802@eukrea.com \
--to=eric@eukrea.com \
--cc=Dinh.Nguyen@freescale.com \
--cc=amit.kucheria@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox