From: Richard Henderson <rth@redhat.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Ingo Molnar <mingo@elte.hu>, Jason Baron <jbaron@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com,
masami.hiramatsu.pt@hitachi.com, fweisbec@gmail.com,
avi@redhat.com, davem@davemloft.net, vgoyal@redhat.com,
sam@ravnborg.org, tony@bakeyournoodle.com, dsd@laptop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] jump label: disable due to compiler bug
Date: Fri, 29 Oct 2010 11:13:52 -0700 [thread overview]
Message-ID: <4CCB0EE0.4000401@redhat.com> (raw)
In-Reply-To: <4CCB08EB.8070004@caviumnetworks.com>
On 10/29/2010 10:48 AM, David Daney wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
>
> Perhaps it could be integrated with the current checks for the presence of 'asm goto'
If you're looking for a cross-compile-able test, you can strip the
testcase down to
extern void abort(void);
void g(int x, ...);
void f(int x)
{
if (x == 0)
g(0);
g(1, 2, 3, 4, 5, 6, 7);
asm goto ("XYZZY" : : : : label);
abort ();
label:
return;
}
and use perl to notice the adjustment to esp before or after XYZZY.
It should be fairly obvious looking at the assembly before and after
the patch.
I don't know what sort of embedded processors supported by linux
actually use ACCUMULATE_OUTGOING_ARGS. Almost all ports don't, so
I'd be pretty comfortable making this a 32-bit x86 only test, and
let other targets just check that the test compiles.
r~
next prev parent reply other threads:[~2010-10-29 18:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:07 [PATCH 0/2] jump label updates Jason Baron
2010-10-27 21:07 ` [PATCH 1/2] move arch_init_ideal_nop5 later Jason Baron
2010-10-27 22:24 ` H. Peter Anvin
2010-10-28 2:11 ` Steven Rostedt
2010-10-28 2:59 ` H. Peter Anvin
2010-10-27 21:07 ` [PATCH 2/2] jump label: disable due to compiler bug Jason Baron
2010-10-27 22:21 ` H. Peter Anvin
2010-10-28 14:17 ` Jason Baron, rth
2010-10-28 18:55 ` David Daney
2010-10-28 20:11 ` Jason Baron
2010-10-29 6:34 ` Ingo Molnar
2010-10-29 12:18 ` Steven Rostedt
2010-10-29 12:22 ` Ingo Molnar
2010-10-29 12:46 ` Steven Rostedt
2010-10-29 13:10 ` Ingo Molnar
2010-10-29 13:35 ` Mathieu Desnoyers
2010-10-29 16:18 ` Steven Rostedt
2010-10-29 17:18 ` David Daney
2010-10-29 17:33 ` Steven Rostedt
2010-10-29 17:48 ` David Daney
2010-10-29 18:03 ` Steven Rostedt
2010-10-29 18:13 ` Richard Henderson [this message]
2010-10-29 18:25 ` Steven Rostedt
2010-10-29 20:15 ` H. Peter Anvin
2010-10-29 20:42 ` Mathieu Desnoyers
2010-10-29 20:47 ` Steven Rostedt
2010-10-29 20:51 ` H. Peter Anvin
2010-10-29 20:58 ` Steven Rostedt
2010-10-30 7:47 ` Andi Kleen
2010-10-30 14:00 ` Steven Rostedt
2010-10-29 20:05 ` Mathieu Desnoyers
2010-10-29 20:44 ` Steven Rostedt
2010-10-29 15:59 ` Richard Henderson
2010-10-27 21:15 ` [PATCH 0/2] jump label updates David Miller
2010-10-28 1:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCB0EE0.4000401@redhat.com \
--to=rth@redhat.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=dsd@laptop.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=tony@bakeyournoodle.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox