public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: Russ Anderson <rja@sgi.com>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86, uv: Fix uv with destroy_irq()
Date: Sat, 30 Oct 2010 01:19:29 -0700	[thread overview]
Message-ID: <4CCBD511.40607@kernel.org> (raw)
In-Reply-To: <20101030034804.GC9557@sgi.com>


Russ found that:

| There is a regression that is causing a NULL pointer dereference
| in free_irte when shutting down xpc.  git bisect narrowed it down
| to git commit d585d060b42bd36f6f0b23ff327d3b91f80c7139, which
| changed free_irte().  Reverse applying the patch fixes the problem.

and he bisected to

| commit d585d060b42bd36f6f0b23ff327d3b91f80c7139
| Author: Thomas Gleixner <tglx@linutronix.de>
|Date:   Sun Oct 10 12:34:27 2010 +0200
|
|   intr_remap: Simplify the code further
|
|   Having irq_2_iommu in struct irq_cfg allows further simplifications.

We need to use irq_mapped() for every irq instead of intr_remapping_enabled
overall

Reported-by: Russ Anderson <rja@sgi.com>
Bisected-by: Russ Anderson <rja@sgi.com>
Tested-by: Russ Anderson <rja@sgi.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/kernel/apic/io_apic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6/arch/x86/kernel/apic/io_apic.c
@@ -3109,7 +3109,7 @@ void destroy_irq(unsigned int irq)
 
 	irq_set_status_flags(irq, IRQ_NOREQUEST|IRQ_NOPROBE);
 
-	if (intr_remapping_enabled)
+	if (irq_remapped(get_irq_chip_data(irq)))
 		free_irte(irq);
 	raw_spin_lock_irqsave(&vector_lock, flags);
 	__clear_irq_vector(irq, cfg);

  reply	other threads:[~2010-10-30  8:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 22:22 [BUG] intr_remap: Simplify the code further Russ Anderson
2010-10-30  0:37 ` Suresh Siddha
2010-10-30  1:50   ` Russ Anderson
2010-10-30  2:55     ` Yinghai Lu
2010-10-30  3:48       ` Russ Anderson
2010-10-30  8:19         ` Yinghai Lu [this message]
2010-10-30  8:22           ` [PATCH] x86, uv: Fix uv with destroy_irq() Thomas Gleixner
2010-10-30  8:36           ` [tip:x86/urgent] x86: Check irq_remapped instead of remapping_enabled in destroy_irq() tip-bot for Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CCBD511.40607@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rja@sgi.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox